Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.2.0
    • Component/s: tooling
    • Labels:
      None

      Description

      I'd like to contribute an openjpa-maven-plugin which got mainly written by Rahul Thakur and me over at codehaus.org. All is ALv2 licensed and the code provenance is pretty clear.

      1. openjpa-tools.tar.gz
        22 kB
        Mark Struberg
      2. openjpa-tools-2.tar.gz
        21 kB
        Mark Struberg

        Activity

        Hide
        Mark Struberg added a comment -

        I just copy the IP clearance log from the list over here, to have all dropped in 1 place.

        IP clearance log openjpa-maven-plugin
        =====================================

        svn log --xml https://svn.codehaus.org/mojo/trunk/mojo/openjpa-maven-plugin | grep author | sort |uniq -c
        5 <author>bentmann</author>
        1 <author>dantran</author>
        1 <author>dennisl</author>
        2 <author>hboutemy</author>
        1 <author>kenney</author>
        1 <author>rafale</author>
        23 <author>rahul</author>
        1 <author>Rahul</author>
        39 <author>struberg</author>

        All committers have ASF CLAs on file.
        This is the list for matching the ids:

        codehaus-id ASF-id realname
        bentmann bentmann Benjamin Bentmann
        dantran dantran Dan Tran
        dennisl dennisl Dennis Lundberg
        hboutemy hboutemy Herve Boutemy
        kenney kenney Kenney Westerhof
        rafale rafale Raphael Pieroni
        rahul/Rahul rinku Rahul Thakur
        struberg struberg Mark Struberg

        The following are only minor changes or got completely reverted in the meantime:

        id: rafale
        <logentry
        revision="3775">
        <author>rafale</author>
        <date>2007-03-26T22:04:14.309648Z</date>
        <msg>Updated pom parent versions to 14 (ensuring builds are not broken by adding dependency when needed)</msg>
        </logentry>
        changelog: http://fisheye.codehaus.org/changelog/mojo/?cs=3775
        IP-clearance comment: not used anymore

        id: kenney
        <logentry
        revision="3527">
        <author>kenney</author>
        <date>2007-03-06T00:49:48.780821Z</date>
        <msg>Fix NPE</msg>
        </logentry>
        changelog: http://fisheye.codehaus.org/changelog/mojo/?cs=3527
        IP-clearance comment: not used anymore, got dropped with my rewrite from cli to java native invocation.

        id: dennisl
        <logentry
        revision="7003">
        <author>dennisl</author>
        <date>2008-05-18T09:46:54.753907Z</date>
        <msg>o Update links to Doxia APT reference.</msg>
        </logentry>
        changelog: http://fisheye.codehaus.org/changelog/mojo/?cs=7003
        IP-clearance comment: only changed the apt syntax link to the new position

        id: dantran
        <logentry
        revision="6814">
        <author>dantran</author>
        <date>2008-04-21T23:22:17.757602Z</date>
        <msg>Update test to use official openjpa release 1.0.2</msg>
        </logentry>
        changelog: http://fisheye.codehaus.org/changelog/mojo/?cs=6814
        IP-clearance comment: only a version pump for the tests.

        id: hboutemy
        <logentry
        revision="10676">
        <author>hboutemy</author>
        <date>2009-09-12T12:11:16.076819Z</date>
        <msg>added XML Schema reference to site.xml</msg>
        </logentry>
        changelog: http://fisheye.codehaus.org/changelog/mojo/?cs=10676
        IP-clearance comment: only xmlns added to the pom.xml

        <logentry
        revision="10669">
        <author>hboutemy</author>
        <date>2009-09-11T16:13:43.402322Z</date>
        <msg>updated POM xsd location to http://maven.apache.org/xsd/maven-4.0.0.xsd</msg>
        </logentry>
        changelog: http://fisheye.codehaus.org/changelog/mojo/?cs=10669
        IP-clearance comment: xsi:schemaLocation for pom schema fixed.

        Contribution statistics:
        $> find src/main/java/ -name *.java | xargs svn blame -x --ignore-eol-style --xml | grep author | sort | uniq -c
        11 <author>bentmann</author>
        459 <author>rahul</author>
        5 <author>Rahul</author>
        561 <author>struberg</author>

        $> find src/test/java/ -name *.java | xargs svn blame -x --ignore-eol-style --xml | grep author | sort | uniq -c
        100 <author>rahul</author>
        80 <author>struberg</author>

        $> find src/it/ -type f | grep -v .svn | xargs svn blame -x --ignore-eol-style --xml | grep author | sort | uniq -c
        259 <author>rahul</author>
        1250 <author>struberg</author>

        Show
        Mark Struberg added a comment - I just copy the IP clearance log from the list over here, to have all dropped in 1 place. IP clearance log openjpa-maven-plugin ===================================== svn log --xml https://svn.codehaus.org/mojo/trunk/mojo/openjpa-maven-plugin | grep author | sort |uniq -c 5 <author>bentmann</author> 1 <author>dantran</author> 1 <author>dennisl</author> 2 <author>hboutemy</author> 1 <author>kenney</author> 1 <author>rafale</author> 23 <author>rahul</author> 1 <author>Rahul</author> 39 <author>struberg</author> All committers have ASF CLAs on file. This is the list for matching the ids: codehaus-id ASF-id realname bentmann bentmann Benjamin Bentmann dantran dantran Dan Tran dennisl dennisl Dennis Lundberg hboutemy hboutemy Herve Boutemy kenney kenney Kenney Westerhof rafale rafale Raphael Pieroni rahul/Rahul rinku Rahul Thakur struberg struberg Mark Struberg The following are only minor changes or got completely reverted in the meantime: id: rafale <logentry revision="3775"> <author>rafale</author> <date>2007-03-26T22:04:14.309648Z</date> <msg>Updated pom parent versions to 14 (ensuring builds are not broken by adding dependency when needed)</msg> </logentry> changelog: http://fisheye.codehaus.org/changelog/mojo/?cs=3775 IP-clearance comment: not used anymore id: kenney <logentry revision="3527"> <author>kenney</author> <date>2007-03-06T00:49:48.780821Z</date> <msg>Fix NPE</msg> </logentry> changelog: http://fisheye.codehaus.org/changelog/mojo/?cs=3527 IP-clearance comment: not used anymore, got dropped with my rewrite from cli to java native invocation. id: dennisl <logentry revision="7003"> <author>dennisl</author> <date>2008-05-18T09:46:54.753907Z</date> <msg>o Update links to Doxia APT reference.</msg> </logentry> changelog: http://fisheye.codehaus.org/changelog/mojo/?cs=7003 IP-clearance comment: only changed the apt syntax link to the new position id: dantran <logentry revision="6814"> <author>dantran</author> <date>2008-04-21T23:22:17.757602Z</date> <msg>Update test to use official openjpa release 1.0.2</msg> </logentry> changelog: http://fisheye.codehaus.org/changelog/mojo/?cs=6814 IP-clearance comment: only a version pump for the tests. id: hboutemy <logentry revision="10676"> <author>hboutemy</author> <date>2009-09-12T12:11:16.076819Z</date> <msg>added XML Schema reference to site.xml</msg> </logentry> changelog: http://fisheye.codehaus.org/changelog/mojo/?cs=10676 IP-clearance comment: only xmlns added to the pom.xml <logentry revision="10669"> <author>hboutemy</author> <date>2009-09-11T16:13:43.402322Z</date> <msg>updated POM xsd location to http://maven.apache.org/xsd/maven-4.0.0.xsd </msg> </logentry> changelog: http://fisheye.codehaus.org/changelog/mojo/?cs=10669 IP-clearance comment: xsi:schemaLocation for pom schema fixed. Contribution statistics: $> find src/main/java/ -name *.java | xargs svn blame -x --ignore-eol-style --xml | grep author | sort | uniq -c 11 <author>bentmann</author> 459 <author>rahul</author> 5 <author>Rahul</author> 561 <author>struberg</author> $> find src/test/java/ -name *.java | xargs svn blame -x --ignore-eol-style --xml | grep author | sort | uniq -c 100 <author>rahul</author> 80 <author>struberg</author> $> find src/it/ -type f | grep -v .svn | xargs svn blame -x --ignore-eol-style --xml | grep author | sort | uniq -c 259 <author>rahul</author> 1250 <author>struberg</author>
        Hide
        Mark Struberg added a comment -

        for the new place, I'd suggest to introduce a new openjpa-tools module containing submodules with the openjpa-maven-plugin and also move the ant task to a submodule:

        ./ openjpa-tools

        • openjpa-maven-plugin
        • openjpa-ant-task

        any thoughts?

        Show
        Mark Struberg added a comment - for the new place, I'd suggest to introduce a new openjpa-tools module containing submodules with the openjpa-maven-plugin and also move the ant task to a submodule: ./ openjpa-tools openjpa-maven-plugin openjpa-ant-task any thoughts?
        Hide
        Michael Dick added a comment -

        We've discussed having a separate module for tools on the dev mailing list a few times.

        http://markmail.org/message/oo6jehutztkkrhom
        http://markmail.org/message/jlf3ec2uponpyic7

        I'd be fine with calling it openjpa-tools, but it might be better to bring it up on dev to read a wider audience..

        Show
        Michael Dick added a comment - We've discussed having a separate module for tools on the dev mailing list a few times. http://markmail.org/message/oo6jehutztkkrhom http://markmail.org/message/jlf3ec2uponpyic7 I'd be fine with calling it openjpa-tools, but it might be better to bring it up on dev to read a wider audience..
        Hide
        Mark Struberg added a comment -

        Txs 4 the input!
        There are a few thematic areas which we need to discuss

        1.)
        > Would suggest that any tool that has a tight version dependency on the openjpa artifacts,
        > should go into the main build instead if in the tools subproject.....

        I think this is true and I honestly don't see any project which is (on a long term) not depending on the openjpa version.
        I originally also thought that the openjpa-maven-plugin can be made independent of the openjpa version. But then you cannot pickup new OpenJPA features in your tool!

        So I'd suggest that the openjpa-tools normally also share the release cycle of the openjpa project. Of course, it is always possible to just release a submodule on it's own! For example, it would easily be possible to backport the openjpa-maven-plugin (or any other new tool) to the 2.1.0 branch and release only the maven plugin as 2.1.0-bp-1.

        2.) should the openjpa-tools be packaged into openjpa-all?
        That depends on how you see this package. Currently it is a jar, so I'd interpret this should only contain the classes needed for the runtime execution. So this should imo not include the various openjpa-tools.

        If openjpa-all would be a binary distribution package, then the tools definitely belong there too. But in this case it should not be a jar but rather a zip + tar.gz!

        Show
        Mark Struberg added a comment - Txs 4 the input! There are a few thematic areas which we need to discuss 1.) > Would suggest that any tool that has a tight version dependency on the openjpa artifacts, > should go into the main build instead if in the tools subproject..... I think this is true and I honestly don't see any project which is (on a long term) not depending on the openjpa version. I originally also thought that the openjpa-maven-plugin can be made independent of the openjpa version. But then you cannot pickup new OpenJPA features in your tool! So I'd suggest that the openjpa-tools normally also share the release cycle of the openjpa project. Of course, it is always possible to just release a submodule on it's own! For example, it would easily be possible to backport the openjpa-maven-plugin (or any other new tool) to the 2.1.0 branch and release only the maven plugin as 2.1.0-bp-1. 2.) should the openjpa-tools be packaged into openjpa-all? That depends on how you see this package. Currently it is a jar, so I'd interpret this should only contain the classes needed for the runtime execution. So this should imo not include the various openjpa-tools. If openjpa-all would be a binary distribution package, then the tools definitely belong there too. But in this case it should not be a jar but rather a zip + tar.gz!
        Hide
        Mark Struberg added a comment -

        please find attached the first version of the Apache openjpa-maven-plugin!

        Show
        Mark Struberg added a comment - please find attached the first version of the Apache openjpa-maven-plugin!
        Hide
        Mark Struberg added a comment -

        updated version which now

        • doesn't need a MySQL installation anymore (temporarily disable one IT)
        • always use the @pom.version@ of the openjpa-* jars in the Integration Tests
        Show
        Mark Struberg added a comment - updated version which now doesn't need a MySQL installation anymore (temporarily disable one IT) always use the @pom.version@ of the openjpa-* jars in the Integration Tests
        Hide
        Michael Dick added a comment -

        Should really be assigned to Mark Struberg, but he isn't in the list. Just wanted to indicate that we're looking at the issue.

        Show
        Michael Dick added a comment - Should really be assigned to Mark Struberg, but he isn't in the list. Just wanted to indicate that we're looking at the issue.
        Hide
        Michael Dick added a comment -

        Back to your comments from Feb 4th.

        1. This seems reasonable. If we were to refactor the enhancer and other tools we'd move this plugin with them. In the meantime it seams reasonable for it to be part of the main project.

        2. I don't see a reason to include a maven plugin in openjpa-all. If you're going to use the maven plugin you'd pick it up from maven central (once we've released it there). Having it in openjpa-all would just clutter it up.

        What about the site for the maven plugin? I'm assuming that entails the usage and other 'generic' maven plugin docs. Seems like it would want to go someone off the main OpenJPA page, or is there a better place for it?

        Show
        Michael Dick added a comment - Back to your comments from Feb 4th. 1. This seems reasonable. If we were to refactor the enhancer and other tools we'd move this plugin with them. In the meantime it seams reasonable for it to be part of the main project. 2. I don't see a reason to include a maven plugin in openjpa-all. If you're going to use the maven plugin you'd pick it up from maven central (once we've released it there). Having it in openjpa-all would just clutter it up. What about the site for the maven plugin? I'm assuming that entails the usage and other 'generic' maven plugin docs. Seems like it would want to go someone off the main OpenJPA page, or is there a better place for it?
        Hide
        Mark Struberg added a comment -

        Hi!
        The site contains usage examples and detailed goal descriptions with all the possible properties of each goal.
        This is a pretty important information and should be provided to the users in any way.
        I'd say that we just configure an own <distributionManagement><site> section for the plugin and link to this page from cwiki or CMS.

        Show
        Mark Struberg added a comment - Hi! The site contains usage examples and detailed goal descriptions with all the possible properties of each goal. This is a pretty important information and should be provided to the users in any way. I'd say that we just configure an own <distributionManagement><site> section for the plugin and link to this page from cwiki or CMS.
        Hide
        Michael Dick added a comment -

        Sorry it's been a while. Having a separate page for the plugin doc makes sense - I'm not sure where to host it, but I'm sure we can work that out.

        How do you feel about the @author tags? In general we do not want them : http://markmail.org/message/7rut2end2vsw5me7, is it okay to remove them before committing?

        Otherwise there's a little bit of pom cleanup (I'm not sure about all the relative paths, and openjpa.version property), but I think it's largely ready to add.

        Show
        Michael Dick added a comment - Sorry it's been a while. Having a separate page for the plugin doc makes sense - I'm not sure where to host it, but I'm sure we can work that out. How do you feel about the @author tags? In general we do not want them : http://markmail.org/message/7rut2end2vsw5me7 , is it okay to remove them before committing? Otherwise there's a little bit of pom cleanup (I'm not sure about all the relative paths, and openjpa.version property), but I think it's largely ready to add.
        Hide
        Mark Struberg added a comment -

        hi! Sure, just drop the @author tags. That was just back from the time at codehaus. Since the mojo projects hosts lots of plugins from different authors, it was important to know whom to ping if there is an problem. That's just not needed anymore.

        Show
        Mark Struberg added a comment - hi! Sure, just drop the @author tags. That was just back from the time at codehaus. Since the mojo projects hosts lots of plugins from different authors, it was important to know whom to ping if there is an problem. That's just not needed anymore.
        Hide
        Michael Dick added a comment -

        I've added the plugin report to the site goal. By default the site is deployed to the user's home public_html directory on people.apache.org. This can easily be changed, and eventually it will reside on the main openjpa page. I'd like to delay moving it until the CMS migration is complete though.
        If anyone wants to take a look the doc is currently up to date at http://people.apache.org/~mikedd/openjpa/openjpa-maven-plugin/

        Show
        Michael Dick added a comment - I've added the plugin report to the site goal. By default the site is deployed to the user's home public_html directory on people.apache.org. This can easily be changed, and eventually it will reside on the main openjpa page. I'd like to delay moving it until the CMS migration is complete though. If anyone wants to take a look the doc is currently up to date at http://people.apache.org/~mikedd/openjpa/openjpa-maven-plugin/

          People

          • Assignee:
            Michael Dick
            Reporter:
            Mark Struberg
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development