[OPENJPA-1912] enhancer generates invalid code if fetch-groups is activated

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 2.0.0, 2.0.1, 2.1.0
• Fix Version/s: 2.2.0
• Component/s: Enhance
• Assignee: Michael Dick
• Reporter: Mark Struberg
• Created: 03/Jan/11 19:48
• Updated: 17/May/13 23:42
• Resolved: 16/Feb/11 02:12

Description

If openjpa.DetachState =fetch-groups is used, the enhancer will add a 'implements Externalizable' + writeExternal + readExternal.

The problem is, that writeExternal and readExternal will also try to externalize the private members of any given superclass. Thus we get a runtime Exception that we are not allowed to access those fields.

Example:

@Entity
public abstract class AbstractGroup {
...
@Temporal(TemporalType.TIMESTAMP)
@TrackChanges
private Date applicationBegin;
...
}

and

@Entity
public class Group extends AbstractGroup {
...
}

will result in the following code (decompiled with jad):

public void writeExternal(ObjectOutput objectoutput)
throws IOException
{
pcWriteUnmanaged(objectoutput);
if(pcStateManager != null)

{ if(pcStateManager.writeDetached(objectoutput)) return; }

else

{ objectoutput.writeObject(pcGetDetachedState()); objectoutput.writeObject(null); }

objectoutput.writeObject(applicationBegin);
objectoutput.writeObject(applicationEnd);
objectoutput.writeObject(applicationLocked);
objectoutput.writeObject(approvalRequired);
...

Issue Links

• is duplicated by: OPENJPA-2351 Subclasses writeExternal method trys to access a super class' private field.
• is related to: OPENJPA-1707 A warning message should be logged when a down level enhanced Entity is encountered.
• relates to: OPENJPA-1704 PCEnhancer incorrectly generates readExternal