Uploaded image for project: 'OpenJPA'
  1. OpenJPA
  2. OPENJPA-1872

Optimize CacheMap read performance

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.1.0
    • 2.1.0
    • performance
    • None

    Description

      While digging through a profile I noticed that for every CacheMap.get(..) call where there is a hit, I was seeing two underlying ConcurrentHashMap.get method calls. This is because we always look to see if a given key exists in the pinned map before looking in the main map. As the code stands today, it is optimized for the existence of entries in the pinned map and I think that is an incorrect assumption.

      With this JIRA I'm going to optimize the get(...), containsKey(...), and containsValue(...) to check the main map for results before looking at the pinned map. In a micro benchmark I observed approximately a 20% improvement in the time required to call get(...) when there is a hit.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            curtisr7 Richard G. Curtis
            curtisr7 Richard G. Curtis
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment