OpenJPA
  1. OpenJPA
  2. OPENJPA-1737

The openjpa-2.0.0.jar does not have its MANIFEST.MF has the first entry

    Details

      Description

      This is a requirement for valid jars and it causes some problems for tools that expect the manifest as the first entry.
      Karaf does that in some places so that it can read the manifest from a remote location without having to download the full jar.

      1. OPENJPA-1737-trunk.diff
        7 kB
        Donald Woods
      2. OPENJPA-1737-20x.diff
        7 kB
        Donald Woods
      3. OPENJPA-1737-13x.diff
        6 kB
        Donald Woods

        Activity

        Guillaume Nodet created issue -
        Hide
        Donald Woods added a comment -

        We're using packaging=bundle and the org.apache.felix.maven-bundle-plugin-2.0.0 to generate the final artifact, so any ideas?

        Show
        Donald Woods added a comment - We're using packaging=bundle and the org.apache.felix.maven-bundle-plugin-2.0.0 to generate the final artifact, so any ideas?
        Donald Woods made changes -
        Field Original Value New Value
        Assignee Donald Woods [ drwoods ]
        Donald Woods made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        Donald Woods added a comment -

        Problem is related to how we're using maven-shade-plugin and maven-bundle-plugin together. Some manifest info was being injected by the shade plugin, which seems to mess the ordering up. Once I moved the injection of manifest data from the shade plugin to the bundle plugin, the manifest file is now the first file in the jar -

        drwoods:openjpa/$ unzip -l target/openjpa-2.1.0-SNAPSHOT.jar
        Archive: target/openjpa-2.1.0-SNAPSHOT.jar
        Length Date Time Name
        -------- ---- ---- ----
        0 07-21-10 14:15 META-INF/
        22219 07-21-10 14:15 META-INF/MANIFEST.MF

        Show
        Donald Woods added a comment - Problem is related to how we're using maven-shade-plugin and maven-bundle-plugin together. Some manifest info was being injected by the shade plugin, which seems to mess the ordering up. Once I moved the injection of manifest data from the shade plugin to the bundle plugin, the manifest file is now the first file in the jar - drwoods:openjpa/$ unzip -l target/openjpa-2.1.0-SNAPSHOT.jar Archive: target/openjpa-2.1.0-SNAPSHOT.jar Length Date Time Name -------- ---- ---- ---- 0 07-21-10 14:15 META-INF/ 22219 07-21-10 14:15 META-INF/MANIFEST.MF
        Donald Woods made changes -
        Fix Version/s 2.0.1 [ 12314532 ]
        Fix Version/s 2.1.0 [ 12314542 ]
        Component/s build / infrastructure [ 12311640 ]
        Component/s osgi [ 12313391 ]
        Hide
        Donald Woods added a comment -

        Patch that corrects the manifest problem in trunk.

        Show
        Donald Woods added a comment - Patch that corrects the manifest problem in trunk.
        Donald Woods made changes -
        Attachment OPENJPA-1737-trunk.diff [ 12450073 ]
        Hide
        Donald Woods added a comment -

        Patches for 2.0.x and 1.3.0 to keep all these branches in sync

        Show
        Donald Woods added a comment - Patches for 2.0.x and 1.3.0 to keep all these branches in sync
        Donald Woods made changes -
        Attachment OPENJPA-1737-20x.diff [ 12450079 ]
        Attachment OPENJPA-1737-13x.diff [ 12450080 ]
        Hide
        Donald Woods added a comment -

        trunk - Committed revision 966353.
        2.0.x - Committed revision 966359.
        1.3.0 - Committed revision 966362.

        Show
        Donald Woods added a comment - trunk - Committed revision 966353. 2.0.x - Committed revision 966359. 1.3.0 - Committed revision 966362.
        Donald Woods made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Fix Version/s 1.3.0 [ 12313326 ]
        Resolution Fixed [ 1 ]
        Hide
        Michael Dick added a comment -

        Closing issues which have been resolved for some time. If the problem persists, please reopen.

        Show
        Michael Dick added a comment - Closing issues which have been resolved for some time. If the problem persists, please reopen.
        Michael Dick made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        6h 1 Donald Woods 21/Jul/10 19:17
        In Progress In Progress Resolved Resolved
        43m 33s 1 Donald Woods 21/Jul/10 20:01
        Resolved Resolved Closed Closed
        60d 20h 38m 1 Michael Dick 20/Sep/10 16:40

          People

          • Assignee:
            Donald Woods
            Reporter:
            Guillaume Nodet
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development