OpenJPA
  1. OpenJPA
  2. OPENJPA-1591

Refactor various parts to allow for greater extensibility

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0-beta3
    • Component/s: kernel
    • Labels:
      None

      Description

      With this JIRA I will be refactoring a couple parts to allow for greater extensibility.

        Activity

        Hide
        Rick Curtis added a comment -

        Refactored AttachManager, StateManagerImpl, and DataCacheScheduler to allow for greater extensibility.

        Show
        Rick Curtis added a comment - Refactored AttachManager, StateManagerImpl, and DataCacheScheduler to allow for greater extensibility.
        Hide
        Pinaki Poddar added a comment -

        StateManagerImpl setPc()

        1. This change needs more explanation of its rationale. A strict bi-directional relation exists between StateManager and PersistenceCapable which is good for overall health of the software. This method seems to weaken that contract.

        2. At present, nothing calls it. It is better to add new methods "for extensibility" as and when they are needed.

        3. The method should be renamed setPersistenceCapable(), if it has to exist.

        4. Consider rolling back this change, for now.

        Show
        Pinaki Poddar added a comment - StateManagerImpl setPc() 1. This change needs more explanation of its rationale. A strict bi-directional relation exists between StateManager and PersistenceCapable which is good for overall health of the software. This method seems to weaken that contract. 2. At present, nothing calls it. It is better to add new methods "for extensibility" as and when they are needed. 3. The method should be renamed setPersistenceCapable(), if it has to exist. 4. Consider rolling back this change, for now.

          People

          • Assignee:
            Rick Curtis
            Reporter:
            Rick Curtis
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development