[OPENJPA-1581] getCache() should throw IllegalStateException if the EMF has been closed.

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.0.0-beta3
• Assignee: Michael Dick
• Reporter: Michael Dick
• Created: 18/Mar/10 14:29
• Updated: 23/Mar/10 18:33
• Resolved: 22/Mar/10 17:26

Description

Per javadoc for EntityManagerFactory.getCache():

/**

• Access the cache that is associated with the entity manager

• factory (the "second level cache").

• @return instance of the Cache interface

• @throws IllegalStateException if the entity manager factory

• has been closed

*/

public Cache getCache();

Throwing a new IllegalStateException is trivial, but throwing the same exception we do for other operations on a closed factory is a bit more involved.

Short reason :

• BrokerFactory.assertOpen() is not public, and the saved exception (used when trace is enabled) is also not available outside of AbstractBrokerFactory.
• EMFImpl.getCache() caches the cache. The same object implements the JPA cache interface and the OpenJPA StoreCache interface. Historically getting the StoreCache does not require the EMF to be open (this may be an oversight).