OpenJPA
  1. OpenJPA
  2. OPENJPA-1563

Better parameter validation on StoreCache.pinAll() method

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-beta2, 2.0.0
    • Fix Version/s: 2.1.0
    • Component/s: datacache
    • Labels:
      None

      Description

      Validation of the second parameter on StoreCache.pinAll could be better. Currently, we assume that the list of oids provided are valid ids for the Class instances being cached. But, if the collection of Objects passed in are not actual ids, then we end up reserving spots in the cache that never get utilized.

      /**

      • Pin the data for the given oids to the cache.
        */
        public void pinAll(Class cls, Object... oids);

      Since the Class type is also passed in, we should be able to validate that the oids passed in are valid. At a minimum, checking if they are oids in the first place would be a good catch. Currently, we do nothing.

        Activity

        Michael Dick made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Rick Curtis made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Rick Curtis made changes -
        Field Original Value New Value
        Fix Version/s 2.1.0 [ 12314542 ]
        Kevin Sutter created issue -

          People

          • Assignee:
            Rick Curtis
            Reporter:
            Kevin Sutter
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development