[OPENJPA-144] JDBCConfigurationImpl does not support JNDI lookup for non-jta-data-source. - ASF JIRA

Voters

Watch issue

Watchers

Link

Clone

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 0.9.7
Component/s: jdbc
Labels:
None
Environment:
WebSphere 6.1, DB2 v8.1 and sequences

Description

A non-jta-data-source is required for DB2 sequences; however, org.apache.openjpa.jdbc.conf.JDBCConfigurationImpl does not support a JNDI lookup for this data source from the openjpa.ConnectionFactory2Name property as documented (refer to section 5.12 and 4.2.1 of the OpenJPA manual).

It seems like the same implementation for the jta-data-source should be implemented for the non-jta-data-source. i.e.

// ADD createConnectionFactory2()
private DecoratingDataSource createConnectionFactory2()

{ DataSource ds = (DataSource) connectionFactory2.get(); if (ds != null) return setupConnectionFactory(ds, true); ds = (DataSource) super.getConnectionFactory2(); // JNDI lookup if (ds == null) ds = DataSourceFactory.newDataSource(this, true); return setupConnectionFactory(ds, true); }

// MODIFY this method
public Object getConnectionFactory2() {
// override to configure data source
if (dataSource2 == null)

{ DecoratingDataSource ds = createConnectionFactory2(); dataSource2 = DataSourceFactory.installDBDictionary (getDBDictionaryInstance(), ds, this, true); }

return dataSource2;
}