OpenJPA
  1. OpenJPA
  2. OPENJPA-1245

Move locking tests to a separate module

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-M2
    • Fix Version/s: 2.0.0-M3
    • Component/s: build / infrastructure
    • Labels:
      None

      Description

      Donald Woods first proposed this change but was met with some concerns [1].

      While it's not particularly pretty moving the tests would allow us to set different derby lock timeouts for persistence-jdbc tests which should speed execution.

      [1] http://markmail.org/thread/eovueydeaihpyd2c

        Activity

        Michael Dick made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Michael Dick made changes -
        Original Estimate 0h [ 0 ]
        Remaining Estimate 0h [ 0 ]
        Donald Woods made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Donald Woods added a comment -

        resolving

        Show
        Donald Woods added a comment - resolving
        Donald Woods made changes -
        Field Original Value New Value
        Fix Version/s 2.0.0-M3 [ 12314148 ]
        Affects Version/s 2.0.0-M2 [ 12313483 ]
        Hide
        Michael Dick added a comment -

        I don't really care where these tests go so long as we can execute the rest of the derby tests in a timely manner.

        The remarks in OPENJPA-991 look like they entail SQL that executes on a particular connection. I'm not sure why this would require moving the tests to the integration module. To me it looks more similar to what we're doing with profiles in o-p-jdbc/pom.xml (although the SQL would probably reside in the testcase itself).

        Show
        Michael Dick added a comment - I don't really care where these tests go so long as we can execute the rest of the derby tests in a timely manner. The remarks in OPENJPA-991 look like they entail SQL that executes on a particular connection. I'm not sure why this would require moving the tests to the integration module. To me it looks more similar to what we're doing with profiles in o-p-jdbc/pom.xml (although the SQL would probably reside in the testcase itself).
        Hide
        Donald Woods added a comment -

        Once the locking code correctly uses server-side locks as described in OPENJPA-991, then these tests are going to require DB specific setup and should be located under openjpa-integration....

        Show
        Donald Woods added a comment - Once the locking code correctly uses server-side locks as described in OPENJPA-991 , then these tests are going to require DB specific setup and should be located under openjpa-integration....
        Hide
        Michael Dick added a comment -

        The locking tests are part of the core JPA functionality. I don't see them as part of our integration with another product (ie a Bean Validation provider, or the TCK). If we split out other long running tests it might make sense to create an openjpa-tests module but integration didn't seem right to me.

        There's really no good place to put these tests. Conceptually they belong in openjpa-persistence-jdbc, but we don't have fine grained control of the JVM used to run the tests (and the derby settings are per jvm).

        Show
        Michael Dick added a comment - The locking tests are part of the core JPA functionality. I don't see them as part of our integration with another product (ie a Bean Validation provider, or the TCK). If we split out other long running tests it might make sense to create an openjpa-tests module but integration didn't seem right to me. There's really no good place to put these tests. Conceptually they belong in openjpa-persistence-jdbc, but we don't have fine grained control of the JVM used to run the tests (and the derby settings are per jvm).
        Hide
        Donald Woods added a comment -

        Any reason why you created a new module under trunk for these instead of putting them under openjpa-integration? I'd prefer not creating another trunk module just for one set of tests.....

        Show
        Donald Woods added a comment - Any reason why you created a new module under trunk for these instead of putting them under openjpa-integration? I'd prefer not creating another trunk module just for one set of tests.....
        Michael Dick created issue -

          People

          • Assignee:
            Michael Dick
            Reporter:
            Michael Dick
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development