OpenJPA
  1. OpenJPA
  2. OPENJPA-1151

Cache the current-time timestamp in AbstractQueryCache.onTypesChanged()

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.3.0, 2.0.0
    • Fix Version/s: 1.3.0, 2.0.0-M3
    • Component/s: jdbc
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      AbstractQueryCache.java contains the following block:

      for (Object o: changedTypes)

      { String name = ((Class) o).getName(); if(!changedClasses.containsKey(name)) changedClasses.put(name, new Long(System.currentTimeMillis())); }

      Suggesting caching the Long containing the entity type's last-modification timestamp outside of the for-loop to improve performance and reduce memory usage.

      1. OpenJPA-trunk-JIRA1151-tests.patch
        20 kB
        Jody Grassel
      2. OpenJPA-trunk-JIRA1151.patch
        20 kB
        Jody Grassel

        Activity

        Jody Grassel created issue -
        Jody Grassel made changes -
        Field Original Value New Value
        Attachment OpenJPA-trunk-JIRA1151.patch [ 12412208 ]
        Jody Grassel made changes -
        Attachment OpenJPA-trunk-JIRA1151-tests.patch [ 12412309 ]
        Donald Woods made changes -
        Assignee Donald Woods [ drwoods ]
        Donald Woods made changes -
        Fix Version/s 1.3.0 [ 12313326 ]
        Fix Version/s 2.0.0-M3 [ 12314148 ]
        Affects Version/s 1.3.0 [ 12313326 ]
        Affects Version/s 2.0.0 [ 12314019 ]
        Donald Woods made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Donald Woods made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Donald Woods made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Donald Woods made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Donald Woods
            Reporter:
            Jody Grassel
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development