OpenJPA
  1. OpenJPA
  2. OPENJPA-1147

Streaming LOB tests and TestAutoIncrement not executed by test suite

    Details

      Description

      InputStreamLobTest and ReaderLobTest tests are not executed because their names end with "Test". TestAutoIncrement is Oracle-specific but is not executed even against Oracle unless you specify -Dplatform=oracle.

      Solution:
      1. Rename streaming LOB tests to start with "Test".
      2. Remove isTargetPlatform call from TestAutoIncrement since the test already has @DatabasePlatform("oracle.jdbc.driver.OracleDriver") annotation.

      BTW, a similar issue is with TestOrderColumnXML.testOrderColumnColumnDefinition. It requires to specify -Dplatform=... not to run it if the database is not Derby but I don't think our database profiles do that. Maybe it's better to just use instanceof on DBDictionary.

        Activity

        Hide
        Michael Dick added a comment -

        I like using instanceof on DBDictionary better than platform, as it verifies the target database (ie goes through all the DBDictionary factory code) and doesn't require manual intervention. Thanks for noticing this.

        Show
        Michael Dick added a comment - I like using instanceof on DBDictionary better than platform, as it verifies the target database (ie goes through all the DBDictionary factory code) and doesn't require manual intervention. Thanks for noticing this.
        Hide
        Milosz Tylenda added a comment -

        Also made the test issue "CREATE SEQUENCE" so that the test runs without manual changes to database.

        Change applied to trunk and 1.3.x branch.

        Show
        Milosz Tylenda added a comment - Also made the test issue "CREATE SEQUENCE" so that the test runs without manual changes to database. Change applied to trunk and 1.3.x branch.

          People

          • Assignee:
            Milosz Tylenda
            Reporter:
            Milosz Tylenda
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development