OpenJPA
  1. OpenJPA
  2. OPENJPA-1117

Missing AgentClass attribute in openjpa-all-xxx.jar manifest.mf

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.0
    • Fix Version/s: 2.0.0-M3
    • Component/s: build / infrastructure
    • Labels:
      None
    • Environment:
      C:\>java -version
      java version "1.6.0_11"
      Java(TM) SE Runtime Environment (build 1.6.0_11-b03)
      Java HotSpot(TM) Client VM (build 11.0-b16, mixed mode, sharing)
    • Patch Info:
      Patch Available

      Description

      OPENJPA-952 added the Agent-Class attribute to the manifest.mf file for the openjpa binary, but the change was missed for openjpa-all. The openjpa-all pom.xml needs to have org.apache.openjpa.enhance.InstrumentationFactory defined as an AgentClass.

      1. OPENJPA-1117-13x.patch
        3 kB
        Donald Woods
      2. OPENJPA-1117-trunk.patch
        3 kB
        Donald Woods
      3. OPENJPA-1117.patch
        2 kB
        Rick Curtis
      4. OPENJPA-1117.patch
        0.9 kB
        Rick Curtis

        Issue Links

          Activity

          Hide
          Rick Curtis added a comment -

          I just ran into another issue, please hold off on committing this patch.

          Show
          Rick Curtis added a comment - I just ran into another issue, please hold off on committing this patch.
          Hide
          Rick Curtis added a comment -

          Updated the patch to also add the Agent-Class attribute to the openjpa-kernel module.

          This is necessary to get the dynamic enhancer to run with the unit tests when running the 'package' target.

          Show
          Rick Curtis added a comment - Updated the patch to also add the Agent-Class attribute to the openjpa-kernel module. This is necessary to get the dynamic enhancer to run with the unit tests when running the 'package' target.
          Hide
          Donald Woods added a comment -

          Yep, will take a look at the patch , as I just ran into this on Win2008 w/ 64bit Sun JDK6 -

          Tests run: 1885, Failures: 24, Errors: 123, Skipped: 0
          Failed to find Agent-Class manifest attribute from C:\Users\drwoods\openjpa\trunk\openjpa-kernel\target\openjpa-kernel-2.0.0-SNAPSHOT.jar
          Failed to find Agent-Class manifest attribute from C:\Users\drwoods\openjpa\trunk\openjpa-kernel\target\openjpa-kernel-2.0.0-SNAPSHOT.jar
          [INFO] ------------------------------------------------------------------------
          [ERROR] BUILD FAILURE

          Show
          Donald Woods added a comment - Yep, will take a look at the patch , as I just ran into this on Win2008 w/ 64bit Sun JDK6 - Tests run: 1885, Failures: 24, Errors: 123, Skipped: 0 Failed to find Agent-Class manifest attribute from C:\Users\drwoods\openjpa\trunk\openjpa-kernel\target\openjpa-kernel-2.0.0-SNAPSHOT.jar Failed to find Agent-Class manifest attribute from C:\Users\drwoods\openjpa\trunk\openjpa-kernel\target\openjpa-kernel-2.0.0-SNAPSHOT.jar [INFO] ------------------------------------------------------------------------ [ERROR] BUILD FAILURE
          Hide
          Donald Woods added a comment -

          and then I ran into the OOM - PermGen space problem, so pulling in parts of OPENJPA-1119 to set the JVM memory options.

          Show
          Donald Woods added a comment - and then I ran into the OOM - PermGen space problem, so pulling in parts of OPENJPA-1119 to set the JVM memory options.
          Hide
          Donald Woods added a comment -

          Patch committed to trunk.

          Show
          Donald Woods added a comment - Patch committed to trunk.
          Hide
          Donald Woods added a comment -

          Patch for 1.3.x branch.

          Show
          Donald Woods added a comment - Patch for 1.3.x branch.
          Hide
          Donald Woods added a comment -

          Rick, thanks for the patch.

          Show
          Donald Woods added a comment - Rick, thanks for the patch.

            People

            • Assignee:
              Donald Woods
              Reporter:
              Rick Curtis
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development