[OOZIE-3373] [core] Logging of lock information is inconsistent

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 4.3.0
• Fix Version/s: trunk, 5.2.0
• Component/s: core
• Assignee: Prabhu Joseph
• Reporter: Prabhu Joseph
• Created: 22/Oct/18 21:34
• Updated: 09/Dec/19 08:54
• Resolved: 05/Nov/18 08:57

Description

The lock resource name getEntityKey() is printed when lock is acquired whereas getName() + "_" + actionId is printed when Could not get lock. This makes difficult to correlate the logs.

LOG.debug("Acquired lock for [{0}] in [{1}]", getEntityKey(), getName());

LOG.debug("Could not get lock [{0}], timed out [{1}]ms, and requeue itself [{2}]", this.toString(),
getLockTimeOut(), getName());

Example:

2018-10-10 12:00:05,698 pool-6-thread-5 DEBUG ActionCheckXCommand:526 - SERVER[dn3-george] USER[-] GROUP[-] TOKEN[-] APP[-] JOB[-] ACTION[0000134-181002155022081-oozie-oozi-W@shell1] Could not get lock [action.check_0000134-181002155022081-oozie-oozi-W@shell1], timed out [5,000]ms, and requeue itself [action.check]

The actual lock it waits is for 0000134-181002155022081-oozie-oozi-W which is not printed.