[OOZIE-1987] Fix existing findbugs warnings

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Fix Version/s: 5.3.0
• Assignee: Unassigned
• Reporter: Robert Kanter
• Created: 29/Aug/14 22:09
• Updated: 11/Nov/22 14:31

Description

Now that we have OOZIE-1793, we should actually fix the warnings that findbugs finds in the existing codebase. It may be a good idea to split this into subtasks or multiple patches as there are a lot of warnings: over 500 in oozie-core alone!

If we think something is ok, but findbugs complains, we should exclude it. There's a way to create a file that lists exclusions (Hadoop does this).

Issue Links

• is duplicated by: OOZIE-3124 address findbugs warnings
• is related to: OOZIE-1793 Improve find bugs reporting for Oozie
• is related to: OOZIE-1986 Add FindBugs report to pre-commit build
• is related to: OOZIE-2933 Switch from Findbugs to Spotbugs
• is related to: OOZIE-3672 Fix current SpotBugs warnings

Sub-Tasks

• [sharelib/spark] Fix Findbugs error: Closed
• Fix "concatenates strings using + in a loop" Findbugs error in oozie-sharelib-streaming: Closed
• Fix Findbugs warnings in oozie-sharelib-hive module: Closed
• Fix Findbugs warnings related to reliance on default encoding in oozie-sharelib-hive2 module: Closed
• [examples] Fix Findbugs warnings: Closed
• Fix Findbugs warnings in oozie-sharelib-pig: Closed
• Fix Findbugs warnings in oozie-sharelib-oozie: Patch Available
• [oozie-client] Fix Findbugs warnings: Closed
• Fix Findbugs warnings related to reliance on default encoding in oozie-core: Closed