Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.1.0
    • Component/s: build
    • Labels:
      None

      Description

      Currently Findbugs complains about the following warnings in the oozie-examples module:

      [INFO] org.apache.oozie.example.DateList.main(String[]) may fail to close stream on exception [org.apache.oozie.example.DateList] At DateList.java:[line 69]
      [INFO] Nullcheck of date at line 55 of value previously dereferenced in org.apache.oozie.example.DateList.main(String[]) [org.apache.oozie.example.DateList, org.apache.oozie.example.DateList] At DateList.java:[line 55]Redundant null check at DateList.java:[line 62]
      [INFO] Private method org.apache.oozie.example.DateList.formatDateUTC(Calendar) is never called [org.apache.oozie.example.DateList] At DateList.java:[line 97]
      [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail to clean up java.io.InputStream [org.apache.oozie.example.LocalOozieExample, org.apache.oozie.example.LocalOozieExample, org.apache.oozie.example.LocalOozieExample, org.apache.oozie.example.LocalOozieExample, org.apache.oozie.example.LocalOozieExample, org.apache.oozie.example.LocalOozieExample, org.apache.oozie.example.LocalOozieExample, org.apache.oozie.example.LocalOozieExample, org.apache.oozie.example.LocalOozieExample] Obligation to clean up resource created at LocalOozieExample.java:[line 72] is not dischargedPath continues at LocalOozieExample.java:[line 76]Path continues at LocalOozieExample.java:[line 77]Path continues at LocalOozieExample.java:[line 78]Path continues at LocalOozieExample.java:[line 81]Path continues at LocalOozieExample.java:[line 88]Path continues at LocalOozieExample.java:[line 89]Path continues at LocalOozieExample.java:[line 91]Path continues at LocalOozieExample.java:[line 100]
      [INFO] org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail to close stream [org.apache.oozie.example.LocalOozieExample] At LocalOozieExample.java:[line 72]
      [INFO] org.apache.oozie.example.Repeatable.getBaseline() may expose internal representation by returning Repeatable.baseline [org.apache.oozie.example.Repeatable] At Repeatable.java:[line 168]
      [INFO] org.apache.oozie.example.Repeatable.setBaseline(Date) may expose internal representation by storing an externally mutable object into Repeatable.baseline [org.apache.oozie.example.Repeatable] At Repeatable.java:[line 172]
      

      They should be fixed to get the code more reliable.

        Attachments

        1. OOZIE-2942.005.patch
          8 kB
          Andras Piros
        2. OOZIE-2942.006.patch
          17 kB
          Andras Piros
        3. OOZIE-2942-003.patch
          3 kB
          Julia Kinga Marton
        4. OOZIE-2942-004.patch
          4 kB
          Julia Kinga Marton
        5. OOZIE-2942-1.patch
          4 kB
          Jan Hentschel
        6. OOZIE-2942-2.patch
          4 kB
          Jan Hentschel

          Activity

            People

            • Assignee:
              kmarton Julia Kinga Marton
              Reporter:
              Jan Hentschel Jan Hentschel
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: