Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-9623

Improvements in LabelReferences class

    Details

      Description

      For Java:
      Current support is only for occurrences like "UtilProperties.getMessage(", but there are other occurrences such as "uiLabelMap.get(" in java as well. Need to add support for same.

      For groovy:
      After some recent improvements for groovy handling, still, there is a possibility that someone is using "UtilProperties.getMessage(" in groovy files as well, so IMO, that must also be handled.

      For XML forms:
      In XML forms current support in handled for auto-fields-service and auto-fields-entity but there are some occurrences of tooltip element of field tag as well, that must also be handled.

      For XML Simple Methods:
      Doesn't handle case of property-to-field and default-message elements. (Separate ticket created OFBIZ-9606, just adding it here for reference)

      1. OFBIZ-9623.patch
        6 kB
        Suraj Khurana

        Issue Links

          Activity

          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Yes Suraj, that's why it's a bug not an improvement

          Show
          jacques.le.roux Jacques Le Roux added a comment - Yes Suraj, that's why it's a bug not an improvement
          Hide
          suraj.khurana Suraj Khurana added a comment -

          Yes, thanks Jacques. It was because actually they were wrongly reported earlier . I also noticed changes in my local box.

          Show
          suraj.khurana Suraj Khurana added a comment - Yes, thanks Jacques. It was because actually they were wrongly reported earlier . I also noticed changes in my local box.
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Forgot one point, on trunk after this changes only 2166 not used labels are reported vs 2184 before

          Show
          jacques.le.roux Jacques Le Roux added a comment - Forgot one point, on trunk after this changes only 2166 not used labels are reported vs 2184 before
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Thanks Suraj,

          The problem I faced yesterday has been fixed since.

          Your patch is in
          trunk r1806266
          R16.11 r1806268
          R15.12, R14.12, R13.07 r1806271

          Show
          jacques.le.roux Jacques Le Roux added a comment - Thanks Suraj, The problem I faced yesterday has been fixed since. Your patch is in trunk r1806266 R16.11 r1806268 R15.12, R14.12, R13.07 r1806271
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          This is a bug not an improvement, wrong report was done

          Show
          jacques.le.roux Jacques Le Roux added a comment - This is a bug not an improvement, wrong report was done
          Hide
          suraj.khurana Suraj Khurana added a comment -

          Yes, I will look for that as well, by the time, you can select all locales, AccountingUiLabel.xml, accounting component
          It is working fine at my end with these parameters. After clicking on find, locales are also loaded.

          Show
          suraj.khurana Suraj Khurana added a comment - Yes, I will look for that as well, by the time, you can select all locales, AccountingUiLabel.xml, accounting component It is working fine at my end with these parameters. After clicking on find, locales are also loaded.
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Thanks Suraj,

          I reviewed and this seems good to me. But I currently can't test because no languages are available in webtools/control/SearchLabels. I guess it's due to the recent changes introduced for the themes, unsure about that yet. Same for OFBIZ-9606

          Show
          jacques.le.roux Jacques Le Roux added a comment - Thanks Suraj, I reviewed and this seems good to me. But I currently can't test because no languages are available in webtools/control/SearchLabels. I guess it's due to the recent changes introduced for the themes, unsure about that yet. Same for OFBIZ-9606
          Hide
          suraj.khurana Suraj Khurana added a comment -

          Here is the proposed patch which covers all the mentioned scenarios.

          Show
          suraj.khurana Suraj Khurana added a comment - Here is the proposed patch which covers all the mentioned scenarios.

            People

            • Assignee:
              jacques.le.roux Jacques Le Roux
              Reporter:
              suraj.khurana Suraj Khurana
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development