Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-9606

LabelManager doesn't search labels in all elements in xml

    Details

      Description

      Currently, label manager for xml search only for fail-property elements in xml files, it should also search for the property-to-field, default-message element in xml files.

      Also, code logic written for fetching these records can be improved.

      1. OFBIZ-9606.patch
        0.8 kB
        Suraj Khurana

        Issue Links

          Activity

          Hide
          suraj.khurana Suraj Khurana added a comment -
          Show
          suraj.khurana Suraj Khurana added a comment - Thanks Jacques Le Roux
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Forgot one point, on trunk after this changes only 2087 not used labels are reported vs 2166 before

          Show
          jacques.le.roux Jacques Le Roux added a comment - Forgot one point, on trunk after this changes only 2087 not used labels are reported vs 2166 before
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Thanks Suraj,

          Your patch is in
          trunk r1806269
          R16.11 r1806270
          R15.12, R14.12, R13.07 r1806272

          Show
          jacques.le.roux Jacques Le Roux added a comment - Thanks Suraj, Your patch is in trunk r1806269 R16.11 r1806270 R15.12, R14.12, R13.07 r1806272
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          This is a bug not an improvement, wrong report was done

          Show
          jacques.le.roux Jacques Le Roux added a comment - This is a bug not an improvement, wrong report was done
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Thanks Suraj,

          I reviewed and this seems good to me. But I currently can't test because no languages are available in webtools/control/SearchLabels. I guess it's due to the recent changes introduced for the themes, unsure about that yet. Same for OFBIZ-9623

          Show
          jacques.le.roux Jacques Le Roux added a comment - Thanks Suraj, I reviewed and this seems good to me. But I currently can't test because no languages are available in webtools/control/SearchLabels. I guess it's due to the recent changes introduced for the themes, unsure about that yet. Same for OFBIZ-9623
          Hide
          suraj.khurana Suraj Khurana added a comment -

          Here is a patch with the proper fix.

          Show
          suraj.khurana Suraj Khurana added a comment - Here is a patch with the proper fix.

            People

            • Assignee:
              jacques.le.roux Jacques Le Roux
              Reporter:
              suraj.khurana Suraj Khurana
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development