Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 16.11.02
    • Fix Version/s: Release Branch 16.11
    • Component/s: accounting
    • Labels:
      None

      Description

      Hi

      In the current 16.11 demo you cannot create a new GL Account manually using our current 16.11 demo. When I try I get the following message

      The Following Errors Occurred:
      The following required parameter is missing: [createGlAccount.glAccountId]

      Steps to recreate the error:

      1. Go to Accounting / Global GL Settings
      2. Click Navigate Accounts (to go into Add mode for adding a new account)
      3. Enter an Account Code (I used 10010)
      4. Enter an Account Name (I used Test Account)
      5. Click Add

      I've also attached a screenshot of the error.

      Thanks
      Sharan

      1. Account_Error.png
        89 kB
        Sharan Foga
      2. OFBIZ-9429.patch
        0.9 kB
        Michael Brohl

        Activity

        Hide
        mbrohl Michael Brohl added a comment -

        The service definition requires the pk fields as INOUT parameters:

        <auto-attributes include="pk" mode="INOUT" optional="false"/>
        

        There is currently no field to enter this code. The solution depends on the business requirement:

        1. should the glAccountId be generated by the system or
        2. should it be entered manually?

        For 1. the solution would be to change the service definition to

        <auto-attributes include="pk" mode="OUT" optional="false"/>
        

        For 2. we must provide an entry field for glAccountId.

        I would prefer 1. What do you think?

        Show
        mbrohl Michael Brohl added a comment - The service definition requires the pk fields as INOUT parameters: <auto-attributes include= "pk" mode= "INOUT" optional= "false" /> There is currently no field to enter this code. The solution depends on the business requirement: should the glAccountId be generated by the system or should it be entered manually? For 1. the solution would be to change the service definition to <auto-attributes include= "pk" mode= "OUT" optional= "false" /> For 2. we must provide an entry field for glAccountId. I would prefer 1. What do you think?
        Hide
        sharan Sharan Foga added a comment - - edited

        Hi Michael, thanks for looking at this and I think that system generated would be the best solution.

        In the past the GLAccountID used to be displayed on that screen and the user could enter it. This changed because users did not want to be restricted to a numeric only GLAccount ID as some prefer alpha numeric codes for their accounts. So the Account Code field was used for this as it is alpha numeric and longer too. Because the GLAccountID was removed from being editable too it this shows me that the plan was for the system to generate it. I suspect there will be other minor fixes as this gets tested throughout the full accounting process flow.

        Show
        sharan Sharan Foga added a comment - - edited Hi Michael, thanks for looking at this and I think that system generated would be the best solution. In the past the GLAccountID used to be displayed on that screen and the user could enter it. This changed because users did not want to be restricted to a numeric only GLAccount ID as some prefer alpha numeric codes for their accounts. So the Account Code field was used for this as it is alpha numeric and longer too. Because the GLAccountID was removed from being editable too it this shows me that the plan was for the system to generate it. I suspect there will be other minor fixes as this gets tested throughout the full accounting process flow.
        Hide
        mbrohl Michael Brohl added a comment -

        This patch auto-generates the glAccountId and solves the error.
        There is, however, a warning that the glAccountId cannot be found after the screen refresh. The UI should be adapted to the auto-generated glAccountId to avoid this. This would be another issue, though.

        Sharan, please check if this is ok now.

        Show
        mbrohl Michael Brohl added a comment - This patch auto-generates the glAccountId and solves the error. There is, however, a warning that the glAccountId cannot be found after the screen refresh. The UI should be adapted to the auto-generated glAccountId to avoid this. This would be another issue, though. Sharan, please check if this is ok now.
        Hide
        sharan Sharan Foga added a comment -

        Hi Michael, thanks for the patch. I've tested it with demo data loaded and also with seed only and it works. One thing I noticed is that the sequencing starts at 10000 which is standard for OFBiz sequences and the demo data for chart of account template starts at 100000 for the glAccountIds so there should be no clash.

        Show
        sharan Sharan Foga added a comment - Hi Michael, thanks for the patch. I've tested it with demo data loaded and also with seed only and it works. One thing I noticed is that the sequencing starts at 10000 which is standard for OFBiz sequences and the demo data for chart of account template starts at 100000 for the glAccountIds so there should be no clash.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        +1

        Show
        jacques.le.roux Jacques Le Roux added a comment - +1
        Hide
        mbrohl Michael Brohl added a comment -

        There would be a clash if you have > 90.000 new accounts with generated glAccountId in the system AND use the demo data but I think it's unlikely. I'll commit the change soon.

        Show
        mbrohl Michael Brohl added a comment - There would be a clash if you have > 90.000 new accounts with generated glAccountId in the system AND use the demo data but I think it's unlikely. I'll commit the change soon.
        Hide
        mbrohl Michael Brohl added a comment -

        This is fixed in r1799793.

        Thanks Sharan for the report.

        Show
        mbrohl Michael Brohl added a comment - This is fixed in r1799793. Thanks Sharan for the report.
        Hide
        mbrohl Michael Brohl added a comment -

        I think this should be backported to 16.11 also.

        Show
        mbrohl Michael Brohl added a comment - I think this should be backported to 16.11 also.
        Hide
        mbrohl Michael Brohl added a comment -

        Backported in r1799858.

        Show
        mbrohl Michael Brohl added a comment - Backported in r1799858.
        Hide
        sharan Sharan Foga added a comment -

        Thanks Michael!

        Show
        sharan Sharan Foga added a comment - Thanks Michael!

          People

          • Assignee:
            mbrohl Michael Brohl
            Reporter:
            sharan Sharan Foga
          • Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development