Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-9351 Remove unnecessary field types
  3. OFBIZ-9355

Replace fields with "id-ne", "id-long-ne" and "id-vlong-ne" by "id", "id-long" and "id-vlong" respectively which are not primary keys

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Trivial
    • Resolution: Done
    • Affects Version/s: Trunk
    • Fix Version/s: Upcoming Release
    • Component/s: ALL COMPONENTS
    • Labels:
      None
    1. OFBIZ-9355.patch
      89 kB
      Aditya Sharma
    2. OFBIZ-9355_plugins.patch
      16 kB
      Aditya Sharma

      Activity

      Hide
      aditya.sharma Aditya Sharma added a comment -

      Thanks Deepak

      Show
      aditya.sharma Aditya Sharma added a comment - Thanks Deepak
      Hide
      deepak.dixit Deepak Dixit added a comment -

      Make sense Aditya, we can add not-null wherever applicable.

      Thanks Aditya for your contribution.
      Your patch has been committed at
      ofbiz-framework trunk at r#1804027
      and ofbiz-plugins trunk at r#1804026

      Show
      deepak.dixit Deepak Dixit added a comment - Make sense Aditya, we can add not-null wherever applicable. Thanks Aditya for your contribution. Your patch has been committed at ofbiz-framework trunk at r#1804027 and ofbiz-plugins trunk at r#1804026
      Hide
      aditya.sharma Aditya Sharma added a comment -

      Replaced fields with field types as "id-ne", "id-long-ne" and "id-vlong-ne" with "id", "id-long" and "id-vlong" for non-primary key fields.
      Though I have not added "not-null" attribute to these fields as it may be quite a bulky task.
      I find these fields empty in demo data itself and it will require checking them at all the instances with data inserted into these entities. So, it is better we explicitly add "not-null" attribute wherever applicable.

      Show
      aditya.sharma Aditya Sharma added a comment - Replaced fields with field types as "id-ne", "id-long-ne" and "id-vlong-ne" with "id", "id-long" and "id-vlong" for non-primary key fields. Though I have not added "not-null" attribute to these fields as it may be quite a bulky task. I find these fields empty in demo data itself and it will require checking them at all the instances with data inserted into these entities. So, it is better we explicitly add "not-null" attribute wherever applicable.

        People

        • Assignee:
          deepak.dixit Deepak Dixit
          Reporter:
          aditya.sharma Aditya Sharma
        • Votes:
          0 Vote for this issue
          Watchers:
          2 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development