Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-9351

Remove unnecessary field types

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • Trunk
    • 17.12.01
    • None
    • None

    Description

      As discussed in http://markmail.org/message/d2tpovewhtotukwa the "not empty" field types ("id-ne", "id-long-ne" and "id-vlong-ne") were initially added to implement validations on data. But, because the validations where only implemented in some place like webtools, it contradicts the distinction to be upheld on various layers. So it is better to remove these field types. So we will remove all those field types and will create sub tickets to replace them in entity definitions by corresponding "id" types.

      When replacing the "not empty" field types in entity definitions by corresponding "id" types we will add a not-null="true" attribute to "makes the field NOT NULL on the database (like primary key fields)" as explained in "not-null" documentation in fieldtypemodel.xsd. We will finally clean the documentation of the "not-null" in fieldtypemodel.xsd.

      Related Links:

      http://ofbiz.135035.n4.nabble.com/EntityEngine-field-types-td2251546.html

      http://markmail.org/message/otec62xiwkpjttkq

      A more vivid description:

      http://ofbiz.markmail.org/thread/c6ee3ewyo6jpik7k

      Attachments

        1. OFBIZ-9351_plugins.patch
          2 kB
          Aditya Sharma
        2. OFBIZ-9351_plugins.patch
          19 kB
          Aditya Sharma
        3. OFBIZ-9351.patch
          10 kB
          Aditya Sharma
        4. OFBIZ-9351.patch
          449 kB
          Aditya Sharma

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            deepak Deepak Dixit
            adityasharma Aditya Sharma
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment