[OFBIZ-9351] Remove unnecessary field types

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: Trunk
• Fix Version/s: 17.12.01
• Assignee: Deepak Dixit
• Reporter: Aditya Sharma
• Created: 08/May/17 09:13
• Updated: 06/Aug/17 05:54
• Resolved: 06/Aug/17 05:54

Description

As discussed in http://markmail.org/message/d2tpovewhtotukwa the "not empty" field types ("id-ne", "id-long-ne" and "id-vlong-ne") were initially added to implement validations on data. But, because the validations where only implemented in some place like webtools, it contradicts the distinction to be upheld on various layers. So it is better to remove these field types. So we will remove all those field types and will create sub tickets to replace them in entity definitions by corresponding "id" types.

When replacing the "not empty" field types in entity definitions by corresponding "id" types we will add a not-null="true" attribute to "makes the field NOT NULL on the database (like primary key fields)" as explained in "not-null" documentation in fieldtypemodel.xsd. We will finally clean the documentation of the "not-null" in fieldtypemodel.xsd.

Related Links:

http://ofbiz.135035.n4.nabble.com/EntityEngine-field-types-td2251546.html

http://markmail.org/message/otec62xiwkpjttkq

A more vivid description:

http://ofbiz.markmail.org/thread/c6ee3ewyo6jpik7k

Sub-Tasks

• Implement "not-null" attribute for a entity field: Closed
• Replace fields with "id-ne", "id-long-ne" and "id-vlong-ne" with "id", "id-long" and "id-vlong" respectively which are primary keys: Closed
• Replace fields with "id-ne", "id-long-ne" and "id-vlong-ne" by "id", "id-long" and "id-vlong" respectively which are not primary keys: Closed