Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: Upcoming Release
    • Fix Version/s: Upcoming Release
    • Component/s: framework
    • Labels:
      None

      Description

      Provide log message to inform users that OFBiz has started.
      This log message will show after all containers/components are loaded:

      **************************************
      ** OFBiz is started and ready for use
      **************************************
      
      1. OFBIZ-9285.patch
        1 kB
        James Yong
      2. OFBIZ-9285.v2.patch
        2 kB
        James Yong
      3. OFBIZ-9285.v2.patch
        2 kB
        James Yong

        Issue Links

          Activity

          Hide
          jamesyong James Yong added a comment -

          Thanks Jacques for the correction.

          Show
          jamesyong James Yong added a comment - Thanks Jacques for the correction.
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Hi James,

          This was only committed in trunk, not the R16.11 branch. It's right because it's an improvement and to avoid regression we normally don't backport improvements only bugs. We sometimes though backport improvements when we are sure no regressions will be put in and when the improvement is worth backporting.

          So I changed the "Fix Version/s" field from 16.11.02 to "Upcoming Release" wich means that this feature will only appear in the next release (ie R17.*).
          This is explained at https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Committers+Roles+and+Responsibilities#OFBizCommittersRolesandResponsibilities-ManageJIRA%27sissues

          Show
          jacques.le.roux Jacques Le Roux added a comment - Hi James, This was only committed in trunk, not the R16.11 branch. It's right because it's an improvement and to avoid regression we normally don't backport improvements only bugs. We sometimes though backport improvements when we are sure no regressions will be put in and when the improvement is worth backporting. So I changed the "Fix Version/s" field from 16.11.02 to "Upcoming Release" wich means that this feature will only appear in the next release (ie R17.*). This is explained at https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Committers+Roles+and+Responsibilities#OFBizCommittersRolesandResponsibilities-ManageJIRA%27sissues
          Hide
          jamesyong James Yong added a comment -

          Removed the OFBIZ-9285.v2.patch with NOTICE change.
          Code committed to SVN.

          Thanks again Jacques Le Roux and Taher Alkhateeb for the guidance.

          Show
          jamesyong James Yong added a comment - Removed the OFBIZ-9285 .v2.patch with NOTICE change. Code committed to SVN. Thanks again Jacques Le Roux and Taher Alkhateeb for the guidance.
          Hide
          taher Taher Alkhateeb added a comment -

          Hi James,

          It looks good to me, good work! I would say go ahead and commit it. Make sure when committing that you use the commit template found in -> https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+commit+message+template

          Show
          taher Taher Alkhateeb added a comment - Hi James, It looks good to me, good work! I would say go ahead and commit it. Make sure when committing that you use the commit template found in -> https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+commit+message+template
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Thanks James,

          Works for me

          Show
          jacques.le.roux Jacques Le Roux added a comment - Thanks James, Works for me
          Hide
          jamesyong James Yong added a comment -

          Thanks Jacques Le Roux.

          Updated the patch with NOTICE change.

          Show
          jamesyong James Yong added a comment - Thanks Jacques Le Roux . Updated the patch with NOTICE change.
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Thanks James,

          Indeed better not wait for ScriptUtil. For slant font we just need to put section in the NOTICE file. I believe this would fit

          Slant by Glenn Chappell 3/93 – based on Standard
          Includes ISO Latin-1
          figlet release 2.1 – 12 Aug 1994
          Permission is hereby given to modify this font, as long as the
          modifier's name is placed on a comment line.

          Show
          jacques.le.roux Jacques Le Roux added a comment - Thanks James, Indeed better not wait for ScriptUtil. For slant font we just need to put section in the NOTICE file. I believe this would fit Slant by Glenn Chappell 3/93 – based on Standard Includes ISO Latin-1 figlet release 2.1 – 12 Aug 1994 Permission is hereby given to modify this font, as long as the modifier's name is placed on a comment line.
          Hide
          jamesyong James Yong added a comment - - edited

          Thanks Taher Alkhateeb.

          Regarding the licensing issue.
          The site at http://patorjk.com/software/taag uses the FIGlet program.
          FIGlet program is New BSD License (1), while the slant font (2) is an 'our' font that comes with the FIGlet program. As the purpose of the program is for the e-mail signature and we are using the standard font, I don't see any attribution required for the outputted text.

          (1) http://www.figlet.org/figlet_history.html
          (2) ftp://ftp.figlet.org/pub/figlet/fonts/ours/slant.flf

          Show
          jamesyong James Yong added a comment - - edited Thanks Taher Alkhateeb . Regarding the licensing issue. The site at http://patorjk.com/software/taag uses the FIGlet program. FIGlet program is New BSD License (1), while the slant font (2) is an 'our' font that comes with the FIGlet program. As the purpose of the program is for the e-mail signature and we are using the standard font, I don't see any attribution required for the outputted text. (1) http://www.figlet.org/figlet_history.html (2) ftp://ftp.figlet.org/pub/figlet/fonts/ours/slant.flf
          Hide
          jamesyong James Yong added a comment -

          Hi Jacques Le Roux,

          Checked that it can take several minutes before the initial queue job runs (see the log below). So i think is better not to depend on ScriptUtil for it.

          2017-03-29 03:37:01,125 |main                 |StartupControlPanel           |I| 
             ____  __________  _
            / __ \/ ____/ __ )(_)___
           / / / / /_  / __  / /_  /
          / /_/ / __/ / /_/ / / / /_
          \____/_/   /_____/_/ /___/ is started and ready.
          
          2017-03-29 03:37:01,253 |OFBiz-JobPoller      |JobManager                    |I| No crashed jobs to re-schedule
          2017-03-29 03:44:01,432 |OFBiz-JobQueue-0     |TransactionUtil               |W| No transaction in place, so not suspending.
          2017-03-29 03:44:01,444 |OFBiz-JobQueue-0     |SequenceUtil                  |I| Got bank of sequenced IDs for [JobSandbox]; curSeqId=14900, maxSeqId=15000, bankSize=100
          2017-03-29 03:44:01,457 |OFBiz-JobQueue-0     |PersistedServiceJob           |I| Job  [Auto-create Fixed Asset Maintenances] Id [14706] -- Next runtime: Wed Mar 29 04:44:01 SGT 2017
          2017-03-29 03:44:01,467 |OFBiz-JobQueue-0     |AbstractEngine                |I| Loaded Service Locations: {eedcc-test=https://localhost:8443/webtools/control/httpService, entity-sync-http=https://localhost:8443/webtools/control/httpService, rita-rmi=rmi://localhost:1099/RMIDispatcher, main-rmi=rmi://localhost:1099/RMIDispatcher, main-soap=http://localhost:8080/webtools/control/SOAPService, entity-sync-rmi=rmi://localhost:1099/RMIDispatcher, main-http=http://localhost:8080/webtools/control/httpService}
          2017-03-29 03:44:01,582 |OFBiz-JobQueue-0     |ScriptUtil                    |I| The following 2 scripting engines were found:
          2017-03-29 03:44:01,582 |OFBiz-JobQueue-0     |ScriptUtil                    |I| Engine name: Groovy Scripting Engine
          2017-03-29 03:44:01,582 |OFBiz-JobQueue-0     |ScriptUtil                    |I|   Version: 2.0
          2017-03-29 03:44:01,582 |OFBiz-JobQueue-0     |ScriptUtil                    |I|   Language: Groovy
          2017-03-29 03:44:01,582 |OFBiz-JobQueue-0     |ScriptUtil                    |I|   Engine supports the following extensions:
          2017-03-29 03:44:01,582 |OFBiz-JobQueue-0     |ScriptUtil                    |I|     groovy
          2017-03-29 03:44:01,583 |OFBiz-JobQueue-0     |ScriptUtil                    |I|   Engine has the following short names:
          2017-03-29 03:44:01,583 |OFBiz-JobQueue-0     |ScriptUtil                    |I|     groovy
          2017-03-29 03:44:01,583 |OFBiz-JobQueue-0     |ScriptUtil                    |I|     Groovy
          2017-03-29 03:44:01,583 |OFBiz-JobQueue-0     |ScriptUtil                    |I| Engine name: Oracle Nashorn
          2017-03-29 03:44:01,584 |OFBiz-JobQueue-0     |ScriptUtil                    |I|   Version: 1.8.0_65
          2017-03-29 03:44:01,584 |OFBiz-JobQueue-0     |ScriptUtil                    |I|   Language: ECMAScript
          2017-03-29 03:44:01,584 |OFBiz-JobQueue-0     |ScriptUtil                    |I|   Engine supports the following extensions:
          2017-03-29 03:44:01,584 |OFBiz-JobQueue-0     |ScriptUtil                    |I|     js
          2017-03-29 03:44:01,584 |OFBiz-JobQueue-0     |ScriptUtil                    |I|   Engine has the following short names:
          2017-03-29 03:44:01,584 |OFBiz-JobQueue-0     |ScriptUtil                    |I|     nashorn
          2017-03-29 03:44:01,584 |OFBiz-JobQueue-0     |ScriptUtil                    |I|     Nashorn
          2017-03-29 03:44:01,584 |OFBiz-JobQueue-0     |ScriptUtil                    |I|     js
          2017-03-29 03:44:01,584 |OFBiz-JobQueue-0     |ScriptUtil                    |I|     JS
          2017-03-29 03:44:01,584 |OFBiz-JobQueue-0     |ScriptUtil                    |I|     JavaScript
          2017-03-29 03:44:01,584 |OFBiz-JobQueue-0     |ScriptUtil                    |I|     javascript
          2017-03-29 03:44:01,584 |OFBiz-JobQueue-0     |ScriptUtil                    |I|     ECMAScript
          2017-03-29 03:44:01,584 |OFBiz-JobQueue-0     |ScriptUtil                    |I|     ecmascript
          2017-03-29 03:44:01,643 |OFBiz-JobQueue-0     |ServiceDispatcher             |T| Sync service [default/fixedAssetPermissionCheck] finished in [171] milliseconds
          2017-03-29 03:44:01,717 |OFBiz-JobQueue-0     |ServiceDispatcher             |T| Sync service [default/createMaintsFromTimeInterval] finished in [252] milliseconds
          2017-03-29 03:45:01,429 |OFBiz-JobQueue-1     |PersistedServiceJob           |I| Job  [Send Email] Id [14800] -- Next runtime: Wed Mar 29 04:00:01 SGT 2017
          2017-03-29 03:45:01,472 |OFBiz-JobQueue-1     |ServiceDispatcher             |T| Sync service [default/sendEmailDated] finished in [42] milliseconds
          2017-03-29 04:00:01,592 |OFBiz-JobQueue-0     |PersistedServiceJob           |I| Job  [Send Email] Id [14901] -- Next runtime: Wed Mar 29 04:15:01 SGT 2017
          2017-03-29 04:00:01,606 |OFBiz-JobQueue-0     |ServiceDispatcher             |T| Sync service [default/sendEmailDated] finished in [13] milliseconds
          2017-03-29 07:56:37,605 |OFBiz-JobQueue-1     |PersistedServiceJob           |I| Job  [Send Email] Id [14902] -- Next runtime: Wed Mar 29 08:11:37 SGT 2017
          2017-03-29 07:56:37,605 |OFBiz-JobQueue-0     |PersistedServiceJob           |I| Job  [Auto-create Fixed Asset Maintenances] Id [14900] -- Next runtime: Wed Mar 29 08:56:37 SGT 2017
          2017-03-29 07:56:37,734 |OFBiz-JobQueue-1     |ServiceDispatcher             |T| Sync service [default/sendEmailDated] finished in [123] milliseconds
          2017-03-29 07:56:37,734 |OFBiz-JobQueue-0     |ServiceDispatcher             |T| Sync service [default/fixedAssetPermissionCheck] finished in [116] milliseconds
          2017-03-29 07:56:37,780 |OFBiz-JobQueue-0     |ServiceDispatcher             |T| Sync service [default/createMaintsFromTimeInterval] finished in [170] milliseconds
          
          Show
          jamesyong James Yong added a comment - Hi Jacques Le Roux , Checked that it can take several minutes before the initial queue job runs (see the log below). So i think is better not to depend on ScriptUtil for it. 2017-03-29 03:37:01,125 |main |StartupControlPanel |I| ____ __________ _ / __ \/ ____/ __ )(_)___ / / / / /_ / __ / /_ / / /_/ / __/ / /_/ / / / /_ \____/_/ /_____/_/ /___/ is started and ready. 2017-03-29 03:37:01,253 |OFBiz-JobPoller |JobManager |I| No crashed jobs to re-schedule 2017-03-29 03:44:01,432 |OFBiz-JobQueue-0 |TransactionUtil |W| No transaction in place, so not suspending. 2017-03-29 03:44:01,444 |OFBiz-JobQueue-0 |SequenceUtil |I| Got bank of sequenced IDs for [JobSandbox]; curSeqId=14900, maxSeqId=15000, bankSize=100 2017-03-29 03:44:01,457 |OFBiz-JobQueue-0 |PersistedServiceJob |I| Job [Auto-create Fixed Asset Maintenances] Id [14706] -- Next runtime: Wed Mar 29 04:44:01 SGT 2017 2017-03-29 03:44:01,467 |OFBiz-JobQueue-0 |AbstractEngine |I| Loaded Service Locations: {eedcc-test=https: //localhost:8443/webtools/control/httpService, entity-sync-http=https://localhost:8443/webtools/control/httpService, rita-rmi=rmi://localhost:1099/RMIDispatcher, main-rmi=rmi://localhost:1099/RMIDispatcher, main-soap=http://localhost:8080/webtools/control/SOAPService, entity-sync-rmi=rmi://localhost:1099/RMIDispatcher, main-http=http://localhost:8080/webtools/control/httpService} 2017-03-29 03:44:01,582 |OFBiz-JobQueue-0 |ScriptUtil |I| The following 2 scripting engines were found: 2017-03-29 03:44:01,582 |OFBiz-JobQueue-0 |ScriptUtil |I| Engine name: Groovy Scripting Engine 2017-03-29 03:44:01,582 |OFBiz-JobQueue-0 |ScriptUtil |I| Version: 2.0 2017-03-29 03:44:01,582 |OFBiz-JobQueue-0 |ScriptUtil |I| Language: Groovy 2017-03-29 03:44:01,582 |OFBiz-JobQueue-0 |ScriptUtil |I| Engine supports the following extensions: 2017-03-29 03:44:01,582 |OFBiz-JobQueue-0 |ScriptUtil |I| groovy 2017-03-29 03:44:01,583 |OFBiz-JobQueue-0 |ScriptUtil |I| Engine has the following short names: 2017-03-29 03:44:01,583 |OFBiz-JobQueue-0 |ScriptUtil |I| groovy 2017-03-29 03:44:01,583 |OFBiz-JobQueue-0 |ScriptUtil |I| Groovy 2017-03-29 03:44:01,583 |OFBiz-JobQueue-0 |ScriptUtil |I| Engine name: Oracle Nashorn 2017-03-29 03:44:01,584 |OFBiz-JobQueue-0 |ScriptUtil |I| Version: 1.8.0_65 2017-03-29 03:44:01,584 |OFBiz-JobQueue-0 |ScriptUtil |I| Language: ECMAScript 2017-03-29 03:44:01,584 |OFBiz-JobQueue-0 |ScriptUtil |I| Engine supports the following extensions: 2017-03-29 03:44:01,584 |OFBiz-JobQueue-0 |ScriptUtil |I| js 2017-03-29 03:44:01,584 |OFBiz-JobQueue-0 |ScriptUtil |I| Engine has the following short names: 2017-03-29 03:44:01,584 |OFBiz-JobQueue-0 |ScriptUtil |I| nashorn 2017-03-29 03:44:01,584 |OFBiz-JobQueue-0 |ScriptUtil |I| Nashorn 2017-03-29 03:44:01,584 |OFBiz-JobQueue-0 |ScriptUtil |I| js 2017-03-29 03:44:01,584 |OFBiz-JobQueue-0 |ScriptUtil |I| JS 2017-03-29 03:44:01,584 |OFBiz-JobQueue-0 |ScriptUtil |I| JavaScript 2017-03-29 03:44:01,584 |OFBiz-JobQueue-0 |ScriptUtil |I| javascript 2017-03-29 03:44:01,584 |OFBiz-JobQueue-0 |ScriptUtil |I| ECMAScript 2017-03-29 03:44:01,584 |OFBiz-JobQueue-0 |ScriptUtil |I| ecmascript 2017-03-29 03:44:01,643 |OFBiz-JobQueue-0 |ServiceDispatcher |T| Sync service [ default /fixedAssetPermissionCheck] finished in [171] milliseconds 2017-03-29 03:44:01,717 |OFBiz-JobQueue-0 |ServiceDispatcher |T| Sync service [ default /createMaintsFromTimeInterval] finished in [252] milliseconds 2017-03-29 03:45:01,429 |OFBiz-JobQueue-1 |PersistedServiceJob |I| Job [Send Email] Id [14800] -- Next runtime: Wed Mar 29 04:00:01 SGT 2017 2017-03-29 03:45:01,472 |OFBiz-JobQueue-1 |ServiceDispatcher |T| Sync service [ default /sendEmailDated] finished in [42] milliseconds 2017-03-29 04:00:01,592 |OFBiz-JobQueue-0 |PersistedServiceJob |I| Job [Send Email] Id [14901] -- Next runtime: Wed Mar 29 04:15:01 SGT 2017 2017-03-29 04:00:01,606 |OFBiz-JobQueue-0 |ServiceDispatcher |T| Sync service [ default /sendEmailDated] finished in [13] milliseconds 2017-03-29 07:56:37,605 |OFBiz-JobQueue-1 |PersistedServiceJob |I| Job [Send Email] Id [14902] -- Next runtime: Wed Mar 29 08:11:37 SGT 2017 2017-03-29 07:56:37,605 |OFBiz-JobQueue-0 |PersistedServiceJob |I| Job [Auto-create Fixed Asset Maintenances] Id [14900] -- Next runtime: Wed Mar 29 08:56:37 SGT 2017 2017-03-29 07:56:37,734 |OFBiz-JobQueue-1 |ServiceDispatcher |T| Sync service [ default /sendEmailDated] finished in [123] milliseconds 2017-03-29 07:56:37,734 |OFBiz-JobQueue-0 |ServiceDispatcher |T| Sync service [ default /fixedAssetPermissionCheck] finished in [116] milliseconds 2017-03-29 07:56:37,780 |OFBiz-JobQueue-0 |ServiceDispatcher |T| Sync service [ default /createMaintsFromTimeInterval] finished in [170] milliseconds
          Hide
          taher Taher Alkhateeb added a comment -

          Okay it's looking cleaner now. Nice work. Is there any licensing stuff to worry about from using this font?

          Show
          taher Taher Alkhateeb added a comment - Okay it's looking cleaner now. Nice work. Is there any licensing stuff to worry about from using this font?
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Hi Taher,

          We crossed on wire. I believe using System.lineSeparator() is always a good idea. I also agree about isolating the ascii art in a method.

          Show
          jacques.le.roux Jacques Le Roux added a comment - Hi Taher, We crossed on wire. I believe using System.lineSeparator() is always a good idea. I also agree about isolating the ascii art in a method.
          Hide
          jamesyong James Yong added a comment -

          Thanks Taher Alkhateeb. I have factored out the code and used the lineSeparator function. Updated OFBIZ-9285.v2.patch

          Show
          jamesyong James Yong added a comment - Thanks Taher Alkhateeb . I have factored out the code and used the lineSeparator function. Updated OFBIZ-9285 .v2.patch
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Nice one,

          You never know if you will not get a job scheduled, even with demo data.

          2017-03-28 17:44:52,911 |main                 |StartupControlPanel           |I|
             ____  __________  _
            / __ \/ ____/ __ )(_)___
           / / / / /_  / __  / /_  /
          / /_/ / __/ / /_/ / / / /_
          \____/_/   /_____/_/ /___/  is started and ready.
          
          2017-03-28 17:44:53,915 |OFBiz-JobPoller      |JobManager                    |I| No crashed jobs to re-schedule
          2017-03-28 17:45:24,502 |OFBiz-JobQueue-0     |TransactionUtil               |W| No transaction in place, so not suspending.
          2017-03-28 17:45:24,518 |OFBiz-JobQueue-0     |SequenceUtil                  |I| Got bank of sequenced IDs for [JobSandbox]; curSeqId=11800, maxSeqId=11900, bankSize=100
          2017-03-28 17:45:24,530 |OFBiz-JobQueue-0     |PersistedServiceJob           |I| Job  [Send Email] Id [11702] -- Next runtime: Tue Mar 28 18:00:24 CEST 2017
          2017-03-28 17:45:24,541 |OFBiz-JobQueue-0     |AbstractEngine                |I| Loaded Service Locations: {eedcc-test=https://localhost:8443/webtools/control/httpService, entity-sync-http=https://localhost:8
          443/webtools/control/httpService, rita-rmi=rmi://localhost:1099/RMIDispatcher, main-rmi=rmi://localhost:1099/RMIDispatcher, main-soap=http://localhost:8080/webtools/control/SOAPService, entity-sync-rmi=rmi://
          localhost:1099/RMIDispatcher, main-http=http://localhost:8080/webtools/control/httpService}
          2017-03-28 17:45:24,615 |OFBiz-JobQueue-0     |ScriptUtil                    |I| The following 2 scripting engines were found:
          2017-03-28 17:45:24,615 |OFBiz-JobQueue-0     |ScriptUtil                    |I| Engine name: Oracle Nashorn
          2017-03-28 17:45:24,616 |OFBiz-JobQueue-0     |ScriptUtil                    |I|   Version: 1.8.0_112
          2017-03-28 17:45:24,616 |OFBiz-JobQueue-0     |ScriptUtil                    |I|   Language: ECMAScript
          2017-03-28 17:45:24,616 |OFBiz-JobQueue-0     |ScriptUtil                    |I|   Engine supports the following extensions:
          2017-03-28 17:45:24,616 |OFBiz-JobQueue-0     |ScriptUtil                    |I|     js
          2017-03-28 17:45:24,616 |OFBiz-JobQueue-0     |ScriptUtil                    |I|   Engine has the following short names:
          2017-03-28 17:45:24,616 |OFBiz-JobQueue-0     |ScriptUtil                    |I|     nashorn
          2017-03-28 17:45:24,616 |OFBiz-JobQueue-0     |ScriptUtil                    |I|     Nashorn
          2017-03-28 17:45:24,616 |OFBiz-JobQueue-0     |ScriptUtil                    |I|     js
          2017-03-28 17:45:24,616 |OFBiz-JobQueue-0     |ScriptUtil                    |I|     JS
          2017-03-28 17:45:24,616 |OFBiz-JobQueue-0     |ScriptUtil                    |I|     JavaScript
          2017-03-28 17:45:24,616 |OFBiz-JobQueue-0     |ScriptUtil                    |I|     javascript
          2017-03-28 17:45:24,616 |OFBiz-JobQueue-0     |ScriptUtil                    |I|     ECMAScript
          2017-03-28 17:45:24,616 |OFBiz-JobQueue-0     |ScriptUtil                    |I|     ecmascript
          2017-03-28 17:45:24,616 |OFBiz-JobQueue-0     |ScriptUtil                    |I| Engine name: Groovy Scripting Engine
          2017-03-28 17:45:24,616 |OFBiz-JobQueue-0     |ScriptUtil                    |I|   Version: 2.0
          2017-03-28 17:45:24,616 |OFBiz-JobQueue-0     |ScriptUtil                    |I|   Language: Groovy
          2017-03-28 17:45:24,616 |OFBiz-JobQueue-0     |ScriptUtil                    |I|   Engine supports the following extensions:
          2017-03-28 17:45:24,616 |OFBiz-JobQueue-0     |ScriptUtil                    |I|     groovy
          2017-03-28 17:45:24,616 |OFBiz-JobQueue-0     |ScriptUtil                    |I|   Engine has the following short names:
          2017-03-28 17:45:24,616 |OFBiz-JobQueue-0     |ScriptUtil                    |I|     groovy
          2017-03-28 17:45:24,616 |OFBiz-JobQueue-0     |ScriptUtil                    |I|     Groovy
          2017-03-28 17:45:24,696 |OFBiz-JobQueue-0     |ServiceDispatcher             |T| Sync service [default/sendEmailDated] finished in [156] milliseconds
          2017-03-28 17:53:54,671 |OFBiz-JobQueue-1     |SequenceUtil                  |I| Got bank of sequenced IDs for [EntitySyncRemove]; curSeqId=13240, maxSeqId=13250, bankSize=10
          2017-03-28 17:53:54,686 |OFBiz-JobQueue-1     |PurgeJob                      |I| Purged job 10807
          2017-03-28 18:00:24,581 |OFBiz-JobQueue-0     |PersistedServiceJob           |I| Job  [Send Email] Id [11800] -- Next runtime: Tue Mar 28 18:15:24 CEST 2017
          2017-03-28 18:00:24,603 |OFBiz-JobQueue-0     |ServiceDispatcher             |T| Sync service [default/sendEmailDated] finished in [21] milliseconds
          2017-03-28 18:08:54,621 |OFBiz-JobQueue-1     |PurgeJob                      |I| Purged job 10816
          2017-03-28 18:15:24,644 |OFBiz-JobQueue-0     |PersistedServiceJob           |I| Job  [Send Email] Id [11801] -- Next runtime: Tue Mar 28 18:30:24 CEST 2017
          2017-03-28 18:15:24,655 |OFBiz-JobQueue-0     |ServiceDispatcher             |T| Sync service [default/sendEmailDated] finished in [11] milliseconds
          

          Maybe we can put it at the end of ScriptUtil (did not check)?

          Show
          jacques.le.roux Jacques Le Roux added a comment - Nice one, You never know if you will not get a job scheduled, even with demo data. 2017-03-28 17:44:52,911 |main |StartupControlPanel |I| ____ __________ _ / __ \/ ____/ __ )(_)___ / / / / /_ / __ / /_ / / /_/ / __/ / /_/ / / / /_ \____/_/ /_____/_/ /___/ is started and ready. 2017-03-28 17:44:53,915 |OFBiz-JobPoller |JobManager |I| No crashed jobs to re-schedule 2017-03-28 17:45:24,502 |OFBiz-JobQueue-0 |TransactionUtil |W| No transaction in place, so not suspending. 2017-03-28 17:45:24,518 |OFBiz-JobQueue-0 |SequenceUtil |I| Got bank of sequenced IDs for [JobSandbox]; curSeqId=11800, maxSeqId=11900, bankSize=100 2017-03-28 17:45:24,530 |OFBiz-JobQueue-0 |PersistedServiceJob |I| Job [Send Email] Id [11702] -- Next runtime: Tue Mar 28 18:00:24 CEST 2017 2017-03-28 17:45:24,541 |OFBiz-JobQueue-0 |AbstractEngine |I| Loaded Service Locations: {eedcc-test=https: //localhost:8443/webtools/control/httpService, entity-sync-http=https://localhost:8 443/webtools/control/httpService, rita-rmi=rmi: //localhost:1099/RMIDispatcher, main-rmi=rmi://localhost:1099/RMIDispatcher, main-soap=http://localhost:8080/webtools/control/SOAPService, entity-sync-rmi=rmi:// localhost:1099/RMIDispatcher, main-http=http: //localhost:8080/webtools/control/httpService} 2017-03-28 17:45:24,615 |OFBiz-JobQueue-0 |ScriptUtil |I| The following 2 scripting engines were found: 2017-03-28 17:45:24,615 |OFBiz-JobQueue-0 |ScriptUtil |I| Engine name: Oracle Nashorn 2017-03-28 17:45:24,616 |OFBiz-JobQueue-0 |ScriptUtil |I| Version: 1.8.0_112 2017-03-28 17:45:24,616 |OFBiz-JobQueue-0 |ScriptUtil |I| Language: ECMAScript 2017-03-28 17:45:24,616 |OFBiz-JobQueue-0 |ScriptUtil |I| Engine supports the following extensions: 2017-03-28 17:45:24,616 |OFBiz-JobQueue-0 |ScriptUtil |I| js 2017-03-28 17:45:24,616 |OFBiz-JobQueue-0 |ScriptUtil |I| Engine has the following short names: 2017-03-28 17:45:24,616 |OFBiz-JobQueue-0 |ScriptUtil |I| nashorn 2017-03-28 17:45:24,616 |OFBiz-JobQueue-0 |ScriptUtil |I| Nashorn 2017-03-28 17:45:24,616 |OFBiz-JobQueue-0 |ScriptUtil |I| js 2017-03-28 17:45:24,616 |OFBiz-JobQueue-0 |ScriptUtil |I| JS 2017-03-28 17:45:24,616 |OFBiz-JobQueue-0 |ScriptUtil |I| JavaScript 2017-03-28 17:45:24,616 |OFBiz-JobQueue-0 |ScriptUtil |I| javascript 2017-03-28 17:45:24,616 |OFBiz-JobQueue-0 |ScriptUtil |I| ECMAScript 2017-03-28 17:45:24,616 |OFBiz-JobQueue-0 |ScriptUtil |I| ecmascript 2017-03-28 17:45:24,616 |OFBiz-JobQueue-0 |ScriptUtil |I| Engine name: Groovy Scripting Engine 2017-03-28 17:45:24,616 |OFBiz-JobQueue-0 |ScriptUtil |I| Version: 2.0 2017-03-28 17:45:24,616 |OFBiz-JobQueue-0 |ScriptUtil |I| Language: Groovy 2017-03-28 17:45:24,616 |OFBiz-JobQueue-0 |ScriptUtil |I| Engine supports the following extensions: 2017-03-28 17:45:24,616 |OFBiz-JobQueue-0 |ScriptUtil |I| groovy 2017-03-28 17:45:24,616 |OFBiz-JobQueue-0 |ScriptUtil |I| Engine has the following short names: 2017-03-28 17:45:24,616 |OFBiz-JobQueue-0 |ScriptUtil |I| groovy 2017-03-28 17:45:24,616 |OFBiz-JobQueue-0 |ScriptUtil |I| Groovy 2017-03-28 17:45:24,696 |OFBiz-JobQueue-0 |ServiceDispatcher |T| Sync service [ default /sendEmailDated] finished in [156] milliseconds 2017-03-28 17:53:54,671 |OFBiz-JobQueue-1 |SequenceUtil |I| Got bank of sequenced IDs for [EntitySyncRemove]; curSeqId=13240, maxSeqId=13250, bankSize=10 2017-03-28 17:53:54,686 |OFBiz-JobQueue-1 |PurgeJob |I| Purged job 10807 2017-03-28 18:00:24,581 |OFBiz-JobQueue-0 |PersistedServiceJob |I| Job [Send Email] Id [11800] -- Next runtime: Tue Mar 28 18:15:24 CEST 2017 2017-03-28 18:00:24,603 |OFBiz-JobQueue-0 |ServiceDispatcher |T| Sync service [ default /sendEmailDated] finished in [21] milliseconds 2017-03-28 18:08:54,621 |OFBiz-JobQueue-1 |PurgeJob |I| Purged job 10816 2017-03-28 18:15:24,644 |OFBiz-JobQueue-0 |PersistedServiceJob |I| Job [Send Email] Id [11801] -- Next runtime: Tue Mar 28 18:30:24 CEST 2017 2017-03-28 18:15:24,655 |OFBiz-JobQueue-0 |ServiceDispatcher |T| Sync service [ default /sendEmailDated] finished in [11] milliseconds Maybe we can put it at the end of ScriptUtil (did not check)?
          Hide
          taher Taher Alkhateeb added a comment -

          Ahh another thing I noticed just now is that you are using \n. I suppose this does not work across all platforms right? Perhaps System.lineSeparator() should be used instead?

          Show
          taher Taher Alkhateeb added a comment - Ahh another thing I noticed just now is that you are using \n. I suppose this does not work across all platforms right? Perhaps System.lineSeparator() should be used instead?
          Hide
          taher Taher Alkhateeb added a comment -

          Hi James,

          I think the code should not be in the start method. It makes it not very readable with the ASCII art. So the code should be isolated in a nice function that hides both the ASCII art and the if condition. For example, you can create a method called printStartupMessageIfEnabled(Config config)

          { // your code here }

          and call it from the start method.

          Show
          taher Taher Alkhateeb added a comment - Hi James, I think the code should not be in the start method. It makes it not very readable with the ASCII art. So the code should be isolated in a nice function that hides both the ASCII art and the if condition. For example, you can create a method called printStartupMessageIfEnabled(Config config) { // your code here } and call it from the start method.
          Hide
          jamesyong James Yong added a comment -

          Hi Jacques Le Roux,

          I do see the scheduled jobs logs immediately after startup.
          How about making the startup message more prominent like the following?

             ____  __________  _    
            / __ \/ ____/ __ )(_)___
           / / / / /_  / __  / /_  /
          / /_/ / __/ / /_/ / / / /_
          \____/_/   /_____/_/ /___/ is started and ready.
          

          Note: Made the art from http://patorjk.com/software/taag. Font name is slant.

          Show
          jamesyong James Yong added a comment - Hi Jacques Le Roux , I do see the scheduled jobs logs immediately after startup. How about making the startup message more prominent like the following? ____ __________ _ / __ \/ ____/ __ )(_)___ / / / / /_ / __ / /_ / / /_/ / __/ / /_/ / / / /_ \____/_/ /_____/_/ /___/ is started and ready. Note: Made the art from http://patorjk.com/software/taag . Font name is slant.
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Thanks James,

          Nice one, apart if you have tons of jobs pending (unlikely for newbies who are the targets here ) it should show and clarify the solution + 1!

          Show
          jacques.le.roux Jacques Le Roux added a comment - Thanks James, Nice one, apart if you have tons of jobs pending (unlikely for newbies who are the targets here ) it should show and clarify the solution + 1!

            People

            • Assignee:
              jamesyong James Yong
              Reporter:
              jamesyong James Yong
            • Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development