Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-8202

Use try-with-resources statement wherever it's possible

        Details

        • Sprint:
          Community Day 3 - 2016

          Description

          This is a non functional change task.

          I have already commited some such changes for OFBIZ-8115 and at r1759082

          1. Text File
            OFBIZ-9410.patch
            3 kB
            Jacques Le Roux

            Issue Links

            is duplicated by

            Bug - A problem which impairs or prevents the functions of the product. OFBIZ-9410 Software not usable all standard installs failed

            • Major - Major loss of function.
            • Closed
            is required by

            Bug - A problem which impairs or prevents the functions of the product. OFBIZ-9410 Software not usable all standard installs failed

            • Major - Major loss of function.
            • Closed

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              jacques.le.roux Jacques Le Roux added a comment -

              Changes in SagePayServices class, including use of "try-with-resources statement" and formatting at r1759944

              Show
              jacques.le.roux Jacques Le Roux added a comment - Changes in SagePayServices class, including use of "try-with-resources statement" and formatting at r1759944
              Hide
              Permalink
              jacques.le.roux Jacques Le Roux added a comment -

              Next step is to have EntityListIterator to implement AutoCloseable, fortunately it has a clean close() method, so it's more about where it's used...

              Show
              jacques.le.roux Jacques Le Roux added a comment - Next step is to have EntityListIterator to implement AutoCloseable, fortunately it has a clean close() method, so it's more about where it's used...
              Hide
              Permalink
              jacques.le.roux Jacques Le Roux added a comment - - edited

              Done for the accounting component at r1761047

              Show
              jacques.le.roux Jacques Le Roux added a comment - - edited Done for the accounting component at r1761047
              Hide
              Permalink
              jacques.le.roux Jacques Le Roux added a comment -

              This is finally done with r1787949

              Show
              jacques.le.roux Jacques Le Roux added a comment - This is finally done with r1787949
              Hide
              Permalink
              jacques.le.roux Jacques Le Roux added a comment - - edited

              I fixed an issue (reported by Daniel Coric on user ML) introduced by r1787949, with another similar, in the R16.11 branch with revision: 1798179

              Show
              jacques.le.roux Jacques Le Roux added a comment - - edited I fixed an issue (reported by Daniel Coric on user ML) introduced by r1787949, with another similar, in the R16.11 branch with revision: 1798179
              Hide
              Permalink
              jacques.le.roux Jacques Le Roux added a comment -

              The OFBIZ-9410.patch should be used to fix the issue introduced by r1787949 reported by Daniel Coric on user ML It concerns only the 16.11.02 release.

              Show
              jacques.le.roux Jacques Le Roux added a comment - The OFBIZ-9410 .patch should be used to fix the issue introduced by r1787949 reported by Daniel Coric on user ML It concerns only the 16.11.02 release.

                People

                • Assignee:
                  jacques.le.roux Jacques Le Roux
                  Reporter:
                  jacques.le.roux Jacques Le Roux
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development

                      Agile