Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-8115

Fixe a bunch of small leaks (closes missing, reported as warnings in Eclipse)

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: ALL COMPONENTS
    • Labels:
      None

      Description

      At r1758927 I tried to fixe a bunch of closes missing, reported as warnings in Eclipse

      Jacopo noticed and reported on dev ML http://markmail.org/message/b4hvzi7foftfq3j5 2 possible issues:

      1. you are adding a close statement to code that already had the close statement in the "finally" block; your modification actually introduces a code pattern that is not correct (if an exception is thrown your close statement are not executed)
      2. I suspect that you are closing the socket connection too early in PcChargeApi

      So I reverted r1758927 to check the issues

        Attachments

          Activity

            People

            • Assignee:
              jacques.le.roux Jacques Le Roux
              Reporter:
              jacques.le.roux Jacques Le Roux
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: