[OFBIZ-8115] Fixe a bunch of small leaks (closes missing, reported as warnings in Eclipse)

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Trunk
• Fix Version/s: 16.11.01
• Component/s: ALL COMPONENTS
• Assignee: Jacques Le Roux
• Reporter: Jacques Le Roux
• Created: 02/Sep/16 11:15
• Updated: 03/Sep/16 13:05
• Resolved: 03/Sep/16 13:05

Description

At r1758927 I tried to fixe a bunch of closes missing, reported as warnings in Eclipse

Jacopo noticed and reported on dev ML http://markmail.org/message/b4hvzi7foftfq3j5 2 possible issues:

1. you are adding a close statement to code that already had the close statement in the "finally" block; your modification actually introduces a code pattern that is not correct (if an exception is thrown your close statement are not executed)
2. I suspect that you are closing the socket connection too early in PcChargeApi

So I reverted r1758927 to check the issues