Details

      Description

      Change 'andCondition' (which uses direct groovy call) to 'conditionFields' in the lookup LookupScreens#LookupContact.

      1. OFBIZ-7657.patch
        1 kB
        Montalbano Florian
      2. OFBIZ-7657.patch
        1 kB
        Montalbano Florian

        Activity

        Hide
        soledad Nicolas Malin added a comment -

        Thanks Florian, commited on trunk at revision 1750492

        Show
        soledad Nicolas Malin added a comment - Thanks Florian, commited on trunk at revision 1750492
        Hide
        deepak.dixit Deepak Dixit added a comment -

        Yup make sense.

        Show
        deepak.dixit Deepak Dixit added a comment - Yup make sense.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Good point Deepak!

        Show
        jacques.le.roux Jacques Le Roux added a comment - Good point Deepak!
        Hide
        Florian M Montalbano Florian added a comment -

        Thanks to the comment from Deepak Dixit, the patch can be even lighter and the code easier to read !

        Show
        Florian M Montalbano Florian added a comment - Thanks to the comment from Deepak Dixit , the patch can be even lighter and the code easier to read !
        Hide
        Florian M Montalbano Florian added a comment -

        Hi Deepak Dixit,
        you are right, both are doing the same thing. I asked in OFBIZ-7576 if there was a difference and Jacques Le Roux said it was just epsilon difference in performance but easier to read. That's why, I'm changing the 'andCondition' to 'conditionFields'.

        I read your other comment and if there is no need to declare the 'conditionFields' as a map then it's even better !

        Is that ok for you ?

        Show
        Florian M Montalbano Florian added a comment - Hi Deepak Dixit , you are right, both are doing the same thing. I asked in OFBIZ-7576 if there was a difference and Jacques Le Roux said it was just epsilon difference in performance but easier to read. That's why, I'm changing the 'andCondition' to 'conditionFields'. I read your other comment and if there is no need to declare the 'conditionFields' as a map then it's even better ! Is that ok for you ?
        Hide
        deepak.dixit Deepak Dixit added a comment -

        Sorry I did not see parent ticket for
        Please ignore this comment.

        Show
        deepak.dixit Deepak Dixit added a comment - Sorry I did not see parent ticket for Please ignore this comment.
        Hide
        deepak.dixit Deepak Dixit added a comment -

        In screen you don't need set conditionFields as empty map
        you can directly set key and minilang internally convert it to map

        +                <set field="conditionFields.roleTypeId" value="CONTACT" />
        
        Show
        deepak.dixit Deepak Dixit added a comment - In screen you don't need set conditionFields as empty map you can directly set key and minilang internally convert it to map + <set field= "conditionFields.roleTypeId" value= "CONTACT" />
        Hide
        deepak.dixit Deepak Dixit added a comment - - edited

        Hi Montalbano Florian,

        Both are doing same thing and we can use both andCondition and conditionFields
        Why you want to change andCondition?

        Show
        deepak.dixit Deepak Dixit added a comment - - edited Hi Montalbano Florian, Both are doing same thing and we can use both andCondition and conditionFields Why you want to change andCondition?
        Hide
        Florian M Montalbano Florian added a comment -

        Here is the patch. I couldn't test it because I didn't find where this lookup was used. Test/Review are welcome !

        Show
        Florian M Montalbano Florian added a comment - Here is the patch. I couldn't test it because I didn't find where this lookup was used. Test/Review are welcome !

          People

          • Assignee:
            soledad Nicolas Malin
            Reporter:
            Florian M Montalbano Florian
          • Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development