Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-7655

Use 'conditionFields' instead of 'andCondition' in Lookup screen

    Details

      Description

      In order to improve a little the readibility, we can replace the use of direct call of groovy in Lookup screen for the autocompletion parameters. Instead, we can use the field 'conditionFields', which is a map key/value, to declare those parameters.

      This is a main task and a sub task will be created for each lookup involved.

        Issue Links

          Activity

          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Florian, in simple cases like that you don't need to create subtasks, a simple patch would do it

          Show
          jacques.le.roux Jacques Le Roux added a comment - Florian, in simple cases like that you don't need to create subtasks, a simple patch would do it
          Hide
          Florian M Montalbano Florian added a comment -

          Ok, I'm taking note for the next time
          Should I create 1 issue by screen or 1 only patch for all the screen ?

          Show
          Florian M Montalbano Florian added a comment - Ok, I'm taking note for the next time Should I create 1 issue by screen or 1 only patch for all the screen ?
          Hide
          deepak.dixit Deepak Dixit added a comment -

          I think one would be good.

          Show
          deepak.dixit Deepak Dixit added a comment - I think one would be good.
          Hide
          jacques.le.roux Jacques Le Roux added a comment - - edited

          In this case, only one patch for all the screens is enough. Because the changes are simple and similar, so easy review and test, and finally less "paperwork".

          Show
          jacques.le.roux Jacques Le Roux added a comment - - edited In this case, only one patch for all the screens is enough. Because the changes are simple and similar, so easy review and test, and finally less "paperwork".
          Hide
          Florian M Montalbano Florian added a comment -

          I'll do that for the next times. Thanks for your answers

          Show
          Florian M Montalbano Florian added a comment - I'll do that for the next times. Thanks for your answers
          Hide
          soledad Nicolas Malin added a comment -

          Agree with this !

          Show
          soledad Nicolas Malin added a comment - Agree with this !
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Thanks All,

          Completed: At revision: 1750543

          I found 2 remaining occurrences, this fixes them in one shoot, as I suggested

          Show
          jacques.le.roux Jacques Le Roux added a comment - Thanks All, Completed: At revision: 1750543 I found 2 remaining occurrences, this fixes them in one shoot, as I suggested

            People

            • Assignee:
              soledad Nicolas Malin
              Reporter:
              Florian M Montalbano Florian
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development