Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-7218

Refactor components regarding groovy file locations

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: ALL COMPONENTS
    • Labels:
      None

      Description

      This is a placeholder issue to capture all tasks and related issues regarding the refactoring of the directory structure of .groovy files.

      See related discussion: http://ofbiz.markmail.org/message/25dse4jke2fp64mx

      Nicolas Malin's comments from OFBIZ-6810

      http://markmail.org/thread/kyhgfykfiwhzllll#query:+page:1+mid:hemokyhcnpe4w5rn+state:results

      At the question :

      Regard to the issue, we have no problem for the java and minilang files but the groovy need a community decision.
      A) All groovy script under the same path src/main/groovy/...
      B) Separate Groovy compiled and scripted like this src/main/groovy/... (pre-compiled Groovy) src/main/scripts/... (parsed Groovy scripts)
      C) Separate Groovy compiled and scripted like this groovy/... (pre-compiled Groovy) groovyScripts/... (parsed Groovy scripts, groovyScripts rather that script because other script languages could be used in the future)
      D) other if you have an ingenious idea

      the result is :

      Total are :
      A) -5
      B) 0
      C) +7
      D) No other proposal

      Now we can move all groovy script present on component://componentname/webapp/componentname/WEB-INF/actions/script.groovy to component://componentname/groovyscript/script.groovy

        Issue Links

        1.
        relocate .groovy files in the accounting component Sub-task Closed Deepak Dixit
         
        2.
        relocate .groovy files in the framework/webtools component Sub-task Closed Deepak Dixit
         
        3.
        relocate .groovy files in the commonext component Sub-task Closed Deepak Dixit
         
        4.
        relocate .groovy files in the content component Sub-task Closed Deepak Dixit
         
        5.
        relocate .groovy files in the humanres component Sub-task Closed Deepak Dixit
         
        6.
        relocate .groovy files in the manufacturing component Sub-task Closed Deepak Dixit
         
        7.
        relocate .groovy files in the marketing component Sub-task Closed Deepak Dixit
         
        8.
        relocate .groovy files in the order component Sub-task Closed Deepak Dixit
         
        9.
        relocate .groovy files in the party component Sub-task Closed Deepak Dixit
         
        10.
        relocate .groovy files in the product component Sub-task Closed Deepak Dixit
         
        11.
        relocate .groovy files in the workeffort component Sub-task Closed Deepak Dixit
         
        12.
        relocate .groovy files in the framework/common component Sub-task Closed Deepak Dixit
         
        13.
        relocate .groovy files in the specialpurpose/assetmaint component Sub-task Closed Deepak Dixit
         
        14.
        relocate .groovy files in the specialpurpose/bi component Sub-task Closed Deepak Dixit
         
        15.
        relocate .groovy files in the specialpurpose/birt component Sub-task Closed Deepak Dixit
         
        16.
        relocate .groovy files in the specialpurpose/ebay component Sub-task Closed Deepak Dixit
         
        17.
        relocate .groovy files in the specialpurpose/ebaystore component Sub-task Closed Deepak Dixit
         
        18.
        relocate .groovy files in the specialpurpose/ecommerce component Sub-task Closed Deepak Dixit
         
        19.
        relocate .groovy files in the specialpurpose/example component Sub-task Closed Deepak Dixit
         
        20.
        relocate .groovy files in the specialpurpose/googlebase component Sub-task Closed Deepak Dixit
         
        21.
        relocate .groovy files in the specialpurpose/hhfacilit component Sub-task Closed Deepak Dixit
         
        22.
        relocate .groovy files in the specialpurpose/lucene component Sub-task Closed Deepak Dixit
         
        23.
        relocate .groovy files in the specialpurpose/passport component Sub-task Closed Deepak Dixit
         
        24.
        relocate .groovy files in the specialpurpose/scrum component Sub-task Closed Deepak Dixit
         
        25.
        relocate .groovy files in the specialpurpose/webpos component Sub-task Closed Deepak Dixit
         
        26.
        Rename .groovy file as per best practises Sub-task Closed Deepak Dixit
         

          Activity

          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          Following Nicolas's comment I also suggested to move minilang scripts from
          component://componentname/script/org/ofbiz
          to
          component://componentname/minilang
          I'll create a Jira for that

          Show
          jacques.le.roux Jacques Le Roux added a comment - Following Nicolas's comment I also suggested to move minilang scripts from component://componentname/script/org/ofbiz to component://componentname/minilang I'll create a Jira for that
          Hide
          deepak.dixit Deepak Dixit added a comment -

          Here is the ticket id for minilang work OFBIZ-7267

          Show
          deepak.dixit Deepak Dixit added a comment - Here is the ticket id for minilang work OFBIZ-7267
          Hide
          deepak.dixit Deepak Dixit added a comment -

          Relocate specialpurpose/projectmgr groovy file at r#1747848

          Show
          deepak.dixit Deepak Dixit added a comment - Relocate specialpurpose/projectmgr groovy file at r#1747848
          Hide
          deepak.dixit Deepak Dixit added a comment -

          I did not change it if-script.groovy name, located at framework/base/ant-scripts/if-script.groovy. I don't know where its included and how to test it.

          Show
          deepak.dixit Deepak Dixit added a comment - I did not change it if-script.groovy name, located at framework/base/ant-scripts/if-script.groovy. I don't know where its included and how to test it.
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          It's ok as is, this is only to enhance Ant. BTW, kudos for the hard work Deepak!

          Show
          jacques.le.roux Jacques Le Roux added a comment - It's ok as is, this is only to enhance Ant. BTW, kudos for the hard work Deepak!
          Hide
          deepak.dixit Deepak Dixit added a comment -
          Show
          deepak.dixit Deepak Dixit added a comment - Thanks Jacques Le Roux

            People

            • Assignee:
              deepak.dixit Deepak Dixit
              Reporter:
              deepak.dixit Deepak Dixit
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development