Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-6924

comments on ordering products should be store driven

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: ecommerce
    • Labels:
      None

      Description

      Currently, in ecommerce/tiny-gismo-GZ-1000-p a comment field is shown.

      This is a result of the following code in productdetail.ftl

      <#assign commentEnable = Static["org.ofbiz.entity.util.EntityUtilProperties"].getPropertyValue("order", "order.item.comment.enable", delegator)>
                  <#if commentEnable.equals("Y")>
                      <#assign orderItemAttr = Static["org.ofbiz.entity.util.EntityUtilProperties"].getPropertyValue("order", "order.item.attr.prefix", delegator)>
                      ${uiLabelMap.CommonComment}&nbsp;<input type="text" name="${orderItemAttr}comment"/>
                  </#if>
      

      Based on the code excerpt this is set by a property value in the order component. However this should be based on a configuration setting in the store.

      1. OFBIZ-6924-product-entitymodel.xml.patch
        1.0 kB
        Pierre Smits
      2. OFBIZ-6924-widgets.patch
        53 kB
        Pierre Smits

        Activity

        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        I agree

        Show
        jacques.le.roux Jacques Le Roux added a comment - I agree
        Hide
        pfm.smits Pierre Smits added a comment -

        This patch addresses the data model

        Show
        pfm.smits Pierre Smits added a comment - This patch addresses the data model
        Hide
        pfm.smits Pierre Smits added a comment - - edited

        This patch addresses the widget part of the store configuration.

        Show
        pfm.smits Pierre Smits added a comment - - edited This patch addresses the widget part of the store configuration.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Hi Pierre,,

        Please check your changes in ProductStoreForms.xml. There is only a real change with allowComment, but a lot more in the pach, thanks!

        Show
        jacques.le.roux Jacques Le Roux added a comment - Hi Pierre,, Please check your changes in ProductStoreForms.xml. There is only a real change with allowComment, but a lot more in the pach, thanks!
        Hide
        pfm.smits Pierre Smits added a comment -

        What I did was remove the form from ProductStoreForms.xml to the also available StoreForms.xml. And adjusted the associated screen in StoreScreens.xml. In order to improve consistency.

        Show
        pfm.smits Pierre Smits added a comment - What I did was remove the form from ProductStoreForms.xml to the also available StoreForms.xml. And adjusted the associated screen in StoreScreens.xml. In order to improve consistency.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Ah indeed, I missed that. Any ideas why we have both? In other words, what decided you to move the form?

        Show
        jacques.le.roux Jacques Le Roux added a comment - Ah indeed, I missed that. Any ideas why we have both? In other words, what decided you to move the form?
        Hide
        pfm.smits Pierre Smits added a comment -

        Why both exist is beyond me, but both exists already a long time. Earliest commit for ProductStoreForms is http://svn.apache.org/viewvc?view=revision&revision=418498 , and for StoreForms is http://svn.apache.org/viewvc?view=revision&revision=916219 .

        The reason why I decided the move is because then (for this) the Naming is in sync. When this is committed I will create a new JIRA regarding the move of the other forms in ProductStoreForms.xml

        Show
        pfm.smits Pierre Smits added a comment - Why both exist is beyond me, but both exists already a long time. Earliest commit for ProductStoreForms is http://svn.apache.org/viewvc?view=revision&revision=418498 , and for StoreForms is http://svn.apache.org/viewvc?view=revision&revision=916219 . The reason why I decided the move is because then (for this) the Naming is in sync. When this is committed I will create a new JIRA regarding the move of the other forms in ProductStoreForms.xml
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Thanks Pierre,

        Dropping ProductStoreForms.xml seems fine to me. Your patch is in trunk at revision: 1735435

        Show
        jacques.le.roux Jacques Le Roux added a comment - Thanks Pierre, Dropping ProductStoreForms.xml seems fine to me. Your patch is in trunk at revision: 1735435

          People

          • Assignee:
            jacques.le.roux Jacques Le Roux
            Reporter:
            pfm.smits Pierre Smits
          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development