Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-6589

In all themes, popup calendar does not work

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: framework
    • Labels:
      None

      Issue Links

        Activity

        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Could you be more specific? Which themes?

        Show
        jacques.le.roux Jacques Le Roux added a comment - Could you be more specific? Which themes?
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        This is not a theme issue, no themes work

        Show
        jacques.le.roux Jacques Le Roux added a comment - This is not a theme issue, no themes work
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        I got this error in date-en-US.js (ligne 47, col. 58)

        too much recursion ...String;$P.toString=function(format){var x=this;if(format&&format.length==1){var ...
        
        Show
        jacques.le.roux Jacques Le Roux added a comment - I got this error in date-en-US.js (ligne 47, col. 58) too much recursion ... String ;$P.toString=function(format){ var x= this ; if (format&&format.length==1){ var ...
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        This error exists in FF, Chrome and IE11

        Show
        jacques.le.roux Jacques Le Roux added a comment - This error exists in FF, Chrome and IE11
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Mmm http://www.datejs.com/ is from 2008, we might need to replace it if we don't find a fix or a workaround...

        Show
        jacques.le.roux Jacques Le Roux added a comment - Mmm http://www.datejs.com/ is from 2008, we might need to replace it if we don't find a fix or a workaround...
        Hide
        jacques.le.roux Jacques Le Roux added a comment - - edited

        This is the line in question:

        $P._toString=$P.toString;$P.toString=function(format){var x=this;if(format&&format.length==1){var c=$C.formatPatterns;x.t=x.toString;switch(format){case"d":return x.t(c.shortDate);case"D":return x.t(c.longDate);case"F":return x.t(c.fullDateTime);case"m":return x.t(c.monthDay);case"r":return x.t(c.rfc1123);case"s":return x.t(c.sortableDateTime);case"t":return x.t(c.shortTime);case"T":return x.t(c.longTime);case"u":return x.t(c.universalSortableDateTime);case"y":return x.t(c.yearMonth);}}
        
        Show
        jacques.le.roux Jacques Le Roux added a comment - - edited This is the line in question: $P._toString=$P.toString;$P.toString=function(format){ var x= this ; if (format&&format.length==1){ var c=$C.formatPatterns;x.t=x.toString; switch (format){ case "d" : return x.t(c.shortDate); case "D" : return x.t(c.longDate); case "F" : return x.t(c.fullDateTime); case "m" : return x.t(c.monthDay); case "r" : return x.t(c.rfc1123); case "s" : return x.t(c.sortableDateTime); case "t" : return x.t(c.shortTime); case "T" : return x.t(c.longTime); case "u" : return x.t(c.universalSortableDateTime); case "y" : return x.t(c.yearMonth);}}
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        And the error is exactly when assigning x here says Firebug

        ...String;$P.toString=function(format){var x=this;if(format&&format.length==1){var ...
        

        Chrome debugger reports this:

        Uncaught RangeError: Maximum call stack size exceeded
        $P.toString @ date-en-US.js:47$P.toString @ date-en-US.js:49$P.toString @ date-en-US.js:49... @ date-en-US.js:49
        
        Show
        jacques.le.roux Jacques Le Roux added a comment - And the error is exactly when assigning x here says Firebug ... String ;$P.toString=function(format){ var x= this ; if (format&&format.length==1){ var ... Chrome debugger reports this: Uncaught RangeError: Maximum call stack size exceeded $P.toString @ date-en-US.js:47$P.toString @ date-en-US.js:49$P.toString @ date-en-US.js:49... @ date-en-US.js:49
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Commenting out

        <set field="layoutSettings.javaScripts[+0]" value="${groovy: org.ofbiz.common.JsLanguageFilesMapping.datejs.getFilePath(initialLocaleComplete)}" global="true" />
        

        in <screen name="GlobalActions"> works but w/o date localisation which is a bummer

        Show
        jacques.le.roux Jacques Le Roux added a comment - Commenting out <set field= "layoutSettings.javaScripts[+0]" value= "${groovy: org.ofbiz.common.JsLanguageFilesMapping.datejs.getFilePath(initialLocaleComplete)}" global= " true " /> in <screen name="GlobalActions"> works but w/o date localisation which is a bummer
        Hide
        pfm.smits Pierre Smits added a comment -

        One would expect that the jquery functions for date/time would render an additional third party set of functionalities unnecessary.

        Show
        pfm.smits Pierre Smits added a comment - One would expect that the jquery functions for date/time would render an additional third party set of functionalities unnecessary.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        This must be checked indeed, it was a much older version then...

        Show
        jacques.le.roux Jacques Le Roux added a comment - This must be checked indeed, it was a much older version then...
        Hide
        jacques.le.roux Jacques Le Roux added a comment - - edited

        I reverted to

        Revision: 1698259
        Author: jleroux
        Date: vendredi 28 août 2015 07:09:35
        Message:
        A patch from Wai for "simple coding cleanup" https://issues.apache.org/jira/browse/OFBIZ-6583

        This fixes and improves CompanyHeader.groovy


        Modified : /ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/order/CompanyHeader.groovy

        It still works then. I will check what happened since...

        Show
        jacques.le.roux Jacques Le Roux added a comment - - edited I reverted to Revision: 1698259 Author: jleroux Date: vendredi 28 août 2015 07:09:35 Message: A patch from Wai for "simple coding cleanup" https://issues.apache.org/jira/browse/OFBIZ-6583 This fixes and improves CompanyHeader.groovy Modified : /ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/order/CompanyHeader.groovy It still works then. I will check what happened since...
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        It's due to

        Revision: 1697574
        Author: deepak
        Date: mardi 25 août 2015 08:40:54
        Message:
        (OFBIZ-6362) Added missing code in header.ftl file to include component specific js file.


        Modified : /ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/includes/headerHead.ftl
        Modified : /ofbiz/trunk/specialpurpose/hhfacility/webapp/hhfacility/includes/header.ftl
        Modified : /ofbiz/trunk/themes/bizznesstime/includes/header.ftl
        Modified : /ofbiz/trunk/themes/bluelight/includes/header.ftl
        Modified : /ofbiz/trunk/themes/droppingcrumbs/includes/header.ftl
        Modified : /ofbiz/trunk/themes/flatgrey/includes/header.ftl
        Modified : /ofbiz/trunk/themes/tomahawk/includes/header.ftl

        Show
        jacques.le.roux Jacques Le Roux added a comment - It's due to Revision: 1697574 Author: deepak Date: mardi 25 août 2015 08:40:54 Message: ( OFBIZ-6362 ) Added missing code in header.ftl file to include component specific js file. Modified : /ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/includes/headerHead.ftl Modified : /ofbiz/trunk/specialpurpose/hhfacility/webapp/hhfacility/includes/header.ftl Modified : /ofbiz/trunk/themes/bizznesstime/includes/header.ftl Modified : /ofbiz/trunk/themes/bluelight/includes/header.ftl Modified : /ofbiz/trunk/themes/droppingcrumbs/includes/header.ftl Modified : /ofbiz/trunk/themes/flatgrey/includes/header.ftl Modified : /ofbiz/trunk/themes/tomahawk/includes/header.ftl
        Hide
        deepak.dixit Deepak Dixit added a comment -

        Let me check...

        Show
        deepak.dixit Deepak Dixit added a comment - Let me check...
        Hide
        deepak.dixit Deepak Dixit added a comment - - edited

        This should be fixed at r#1700250. Removed date picker localization data from theme file.
        GlobalActions decorator will generate and include the localization file in GlobalDecorator.

        Thanks Wai for the reporting the bug, and Thanks Jacques and Pierre for the discussion.

        Show
        deepak.dixit Deepak Dixit added a comment - - edited This should be fixed at r#1700250. Removed date picker localization data from theme file. GlobalActions decorator will generate and include the localization file in GlobalDecorator. Thanks Wai for the reporting the bug, and Thanks Jacques and Pierre for the discussion.

          People

          • Assignee:
            deepak.dixit Deepak Dixit
            Reporter:
            wt Wai
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development