Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: Trunk, 16.11.01
    • Fix Version/s: 16.11.01
    • Component/s: framework
    • Labels:
      None
    1. bbasic.zip
      1.03 MB
      Pierre Smits
    2. OFBIZ-6263-BlueLight-header.ftl.patch
      1 kB
      Pierre Smits
    3. OFBIZ-6362-bbasic-theme.patch
      1.20 MB
      Pierre Smits
    4. OFBIZ-6362-BizznessTime-header.ftl.patch
      1 kB
      Pierre Smits
    5. OFBIZ-6362-BizznessTimeThemeData.xml.patch
      7 kB
      Pierre Smits
    6. OFBIZ-6362-BlueLightThemeData.xml.patch
      7 kB
      Pierre Smits
    7. OFBIZ-6362-CommonScreens.xml.patch
      6 kB
      Pierre Smits
    8. OFBIZ-6362-DroppingCrumbs-header.ftl.patch
      1 kB
      Pierre Smits
    9. OFBIZ-6362-DroppingCrumbsThemeData.xml.patch
      8 kB
      Pierre Smits
    10. OFBIZ-6362-FlatGrey-header.ftl.patch
      1 kB
      Pierre Smits
    11. OFBIZ-6362-FlatGreyThemeData.xml.patch
      7 kB
      Pierre Smits
    12. OFBIZ-6362-sunrise-theme.patch
      1.21 MB
      Pierre Smits
    13. OFBIZ-6362-Tomahawk-header.ftl.patch
      1 kB
      Pierre Smits
    14. OFBIZ-6362-TomahawkThemeData.xml.patch
      7 kB
      Pierre Smits
    15. sunrise.zip
      1.04 MB
      Pierre Smits

      Issue Links

        Activity

        Hide
        pfm.smits Pierre Smits added a comment -

        This patch addresses the bluelight theme

        Show
        pfm.smits Pierre Smits added a comment - This patch addresses the bluelight theme
        Hide
        pfm.smits Pierre Smits added a comment -

        This patch addresses the issue of loading of some javascript files twice.

        Show
        pfm.smits Pierre Smits added a comment - This patch addresses the issue of loading of some javascript files twice.
        Hide
        pfm.smits Pierre Smits added a comment -

        These patches address the BizznessTime theme

        Show
        pfm.smits Pierre Smits added a comment - These patches address the BizznessTime theme
        Hide
        pfm.smits Pierre Smits added a comment -

        These patches address the DroppingCrumbs theme.

        Show
        pfm.smits Pierre Smits added a comment - These patches address the DroppingCrumbs theme.
        Hide
        pfm.smits Pierre Smits added a comment -

        These patches address the FlatGrey theme

        Show
        pfm.smits Pierre Smits added a comment - These patches address the FlatGrey theme
        Hide
        pfm.smits Pierre Smits added a comment -

        These patches address the Tomahawk theme

        Show
        pfm.smits Pierre Smits added a comment - These patches address the Tomahawk theme
        Hide
        adrianc@hlmksw.com Adrian Crum added a comment -

        Pierre,

        Thank you for working on this. When you are finished, please assign it to me.

        Show
        adrianc@hlmksw.com Adrian Crum added a comment - Pierre, Thank you for working on this. When you are finished, please assign it to me.
        Hide
        pfm.smits Pierre Smits added a comment -

        Thanks Adrian. Will do.

        Show
        pfm.smits Pierre Smits added a comment - Thanks Adrian. Will do.
        Hide
        pfm.smits Pierre Smits added a comment -

        Question: How shall we deal with the '<screen name="SimpleDecorator">'?

        Have a simple theme for this? Or?

        Show
        pfm.smits Pierre Smits added a comment - Question: How shall we deal with the '<screen name="SimpleDecorator">'? Have a simple theme for this? Or?
        Hide
        pfm.smits Pierre Smits added a comment -

        This patch addresses the removal of hard coded css and javascript references in CommonScreens.xml, regarding:

        • <screen name="GlobalActions">
        • <screen name="LookupDecorator">

        <screen name="SimpleDecorator"> is not adjusted for now.

        Show
        pfm.smits Pierre Smits added a comment - This patch addresses the removal of hard coded css and javascript references in CommonScreens.xml, regarding: <screen name="GlobalActions"> <screen name="LookupDecorator"> <screen name="SimpleDecorator"> is not adjusted for now.
        Hide
        adrianc@hlmksw.com Adrian Crum added a comment -

        The SimpleDecorator can be treated the same as GlobalDecorator.

        Show
        adrianc@hlmksw.com Adrian Crum added a comment - The SimpleDecorator can be treated the same as GlobalDecorator.
        Hide
        adrianc@hlmksw.com Adrian Crum added a comment -

        JQuery is still referenced in the Global Decorator - lines 147-151. Those lines will need to be moved to the theme's header.ftl file.

        Show
        adrianc@hlmksw.com Adrian Crum added a comment - JQuery is still referenced in the Global Decorator - lines 147-151. Those lines will need to be moved to the theme's header.ftl file.
        Hide
        pfm.smits Pierre Smits added a comment -

        Adjustment of the SimpleDecorator needs to be done in a separate issue, as it impacts more than just the screen in CommonScreens.xml.

        Show
        pfm.smits Pierre Smits added a comment - Adjustment of the SimpleDecorator needs to be done in a separate issue, as it impacts more than just the screen in CommonScreens.xml.
        Hide
        pfm.smits Pierre Smits added a comment -

        Those lines are not referencing jquery directly, but some java code in JsLanguageFilesMapping.java and JsLanguageFileMappingCreator.java, referencing template JsLanguageFilesMapping.ftl

        Cleaning up lines 147-151 and potentially (re)moving the code in JsLanguageFilesMapping.java, JsLanguageFileMappingCreator.java and JsLanguageFilesMapping.ftl will require more effort and should be assessed independently in a separate issue.

        Show
        pfm.smits Pierre Smits added a comment - Those lines are not referencing jquery directly, but some java code in JsLanguageFilesMapping.java and JsLanguageFileMappingCreator.java, referencing template JsLanguageFilesMapping.ftl Cleaning up lines 147-151 and potentially (re)moving the code in JsLanguageFilesMapping.java, JsLanguageFileMappingCreator.java and JsLanguageFilesMapping.ftl will require more effort and should be assessed independently in a separate issue.
        Hide
        pfm.smits Pierre Smits added a comment -

        The issue OFBIZ-6367 has been created to address this.

        Show
        pfm.smits Pierre Smits added a comment - The issue OFBIZ-6367 has been created to address this.
        Hide
        pfm.smits Pierre Smits added a comment -

        This zip file contains the Bootstrap based Sunrise theme that was developed as part of the Bootstrap theme through the OFBIZ-5840 issue.

        Show
        pfm.smits Pierre Smits added a comment - This zip file contains the Bootstrap based Sunrise theme that was developed as part of the Bootstrap theme through the OFBIZ-5840 issue.
        Hide
        pfm.smits Pierre Smits added a comment -

        This zip file contains the Bootstrap based Basic theme that was developed as part of the Bootstrap theme through the OFBIZ-5840 issue.

        Show
        pfm.smits Pierre Smits added a comment - This zip file contains the Bootstrap based Basic theme that was developed as part of the Bootstrap theme through the OFBIZ-5840 issue.
        Hide
        pfm.smits Pierre Smits added a comment -

        Adding the Bootstrap Basic Theme as a patch file.

        Show
        pfm.smits Pierre Smits added a comment - Adding the Bootstrap Basic Theme as a patch file.
        Hide
        pfm.smits Pierre Smits added a comment -

        Adding the Bootstrap based Sunrise Theme as a patch file.

        Show
        pfm.smits Pierre Smits added a comment - Adding the Bootstrap based Sunrise Theme as a patch file.
        Hide
        adrianc@hlmksw.com Adrian Crum added a comment -

        Fixed in rev 1686655. I did not add the new visual themes because that is out of scope for this issue.

        Show
        adrianc@hlmksw.com Adrian Crum added a comment - Fixed in rev 1686655. I did not add the new visual themes because that is out of scope for this issue.
        Hide
        tzngvi Wei Zhang added a comment - - edited

        I don't think we should hard code localization js files below to seed data

             <VisualThemeResource visualThemeId="BIZZNESS_TIME" resourceTypeEnumId="VT_HDR_JAVASCRIPT" resourceValue="/images/jquery/ui/i18n/jquery.ui.datepicker-en.js" sequenceId="04"/>
            <VisualThemeResource visualThemeId="BIZZNESS_TIME" resourceTypeEnumId="VT_HDR_JAVASCRIPT" resourceValue="/images/jquery/plugins/datejs/date-en-US.js" sequenceId="06"/>
            <VisualThemeResource visualThemeId="BIZZNESS_TIME" resourceTypeEnumId="VT_HDR_JAVASCRIPT" resourceValue="/images/jquery/plugins/datetimepicker/localization/jquery-ui-timepicker-en.js" sequenceId="08"/>
            <VisualThemeResource visualThemeId="BIZZNESS_TIME" resourceTypeEnumId="VT_HDR_JAVASCRIPT" resourceValue="/images/jquery/plugins/validate/localization/messages_en.js" sequenceId="13"/>
        

        And there is no way to output the localization js files defined GlobalActions in framework\common\widget\CommonScreens.xml

          <set field="layoutSettings.javaScripts[+0]" value="${groovy: org.ofbiz.common.JsLanguageFilesMapping.datejs.getFilePath(initialLocaleComplete)}" global="true" />
                        <set field="layoutSettings.javaScripts[+0]" value="${groovy: org.ofbiz.common.JsLanguageFilesMapping.jquery.getFilePath(initialLocaleComplete)}" global="true" />
                        <set field="layoutSettings.javaScripts[+0]" value="${groovy: org.ofbiz.common.JsLanguageFilesMapping.validation.getFilePath(initialLocaleComplete)}" global="true" />
                        <set field="layoutSettings.javaScripts[+0]" value="${groovy: org.ofbiz.common.JsLanguageFilesMapping.dateTime.getFilePath(initialLocaleComplete)}" global="true" />
        
        Show
        tzngvi Wei Zhang added a comment - - edited I don't think we should hard code localization js files below to seed data <VisualThemeResource visualThemeId= "BIZZNESS_TIME" resourceTypeEnumId= "VT_HDR_JAVASCRIPT" resourceValue= "/images/jquery/ui/i18n/jquery.ui.datepicker-en.js" sequenceId= "04" /> <VisualThemeResource visualThemeId= "BIZZNESS_TIME" resourceTypeEnumId= "VT_HDR_JAVASCRIPT" resourceValue= "/images/jquery/plugins/datejs/date-en-US.js" sequenceId= "06" /> <VisualThemeResource visualThemeId= "BIZZNESS_TIME" resourceTypeEnumId= "VT_HDR_JAVASCRIPT" resourceValue= "/images/jquery/plugins/datetimepicker/localization/jquery-ui-timepicker-en.js" sequenceId= "08" /> <VisualThemeResource visualThemeId= "BIZZNESS_TIME" resourceTypeEnumId= "VT_HDR_JAVASCRIPT" resourceValue= "/images/jquery/plugins/validate/localization/messages_en.js" sequenceId= "13" /> And there is no way to output the localization js files defined GlobalActions in framework\common\widget\CommonScreens.xml <set field= "layoutSettings.javaScripts[+0]" value= "${groovy: org.ofbiz.common.JsLanguageFilesMapping.datejs.getFilePath(initialLocaleComplete)}" global= " true " /> <set field= "layoutSettings.javaScripts[+0]" value= "${groovy: org.ofbiz.common.JsLanguageFilesMapping.jquery.getFilePath(initialLocaleComplete)}" global= " true " /> <set field= "layoutSettings.javaScripts[+0]" value= "${groovy: org.ofbiz.common.JsLanguageFilesMapping.validation.getFilePath(initialLocaleComplete)}" global= " true " /> <set field= "layoutSettings.javaScripts[+0]" value= "${groovy: org.ofbiz.common.JsLanguageFilesMapping.dateTime.getFilePath(initialLocaleComplete)}" global= " true " />
        Hide
        deepak.dixit Deepak Dixit added a comment -

        Added missing code at r#1697574 to include the component specific js file in header.ftl.

        Show
        deepak.dixit Deepak Dixit added a comment - Added missing code at r#1697574 to include the component specific js file in header.ftl.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        I noticed this comment but then forgot to comment myself. I agree with Wei, also see OFBIZ-6589 for last commit below

        Show
        jacques.le.roux Jacques Le Roux added a comment - I noticed this comment but then forgot to comment myself. I agree with Wei, also see OFBIZ-6589 for last commit below
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Good luck with solving OFBIZ-6589 w/o reverting all changes done here :/ At least we need to better deal with

        <VisualThemeResource visualThemeId="TOMAHAWK" resourceTypeEnumId="VT_HDR_JAVASCRIPT" resourceValue="/images/jquery/plugins/datejs/date-en-US.js" sequenceId="06"/>

        And why is the related code still present in <screen name="GlobalActions"> :-o ?

        Show
        jacques.le.roux Jacques Le Roux added a comment - Good luck with solving OFBIZ-6589 w/o reverting all changes done here :/ At least we need to better deal with <VisualThemeResource visualThemeId="TOMAHAWK" resourceTypeEnumId="VT_HDR_JAVASCRIPT" resourceValue="/images/jquery/plugins/datejs/date-en-US.js" sequenceId="06"/> And why is the related code still present in <screen name="GlobalActions"> :-o ?

          People

          • Assignee:
            deepak.dixit Deepak Dixit
            Reporter:
            pfm.smits Pierre Smits
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development