Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-6403

Form widget <hyperlink> id not supported by MacroFormRenderer.java

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: framework
    • Labels:
      None

      Description

      This problem was encountered when trying to patch OFBIZ-6402.

      1. OFBIZ-6403_fix.patch
        1.0 kB
        Christian Carlow
      2. OFBIZ-6403.patch
        4 kB
        Christian Carlow

        Issue Links

          Activity

          Hide
          ofbizzer Christian Carlow added a comment -

          This patch was extracted form OFBIZ-6402 to support form widget field <hyperlink> id attribute settings.

          Show
          ofbizzer Christian Carlow added a comment - This patch was extracted form OFBIZ-6402 to support form widget field <hyperlink> id attribute settings.
          Hide
          pfm.smits Pierre Smits added a comment -

          It seems to me that this is related to OFBIZ-6034 (and associated/related issues).

          Show
          pfm.smits Pierre Smits added a comment - It seems to me that this is related to OFBIZ-6034 (and associated/related issues).
          Hide
          jacques.le.roux Jacques Le Roux added a comment -

          I agree with Pierre, relation done

          Show
          jacques.le.roux Jacques Le Roux added a comment - I agree with Pierre, relation done
          Hide
          soledad Nicolas Malin added a comment -

          Thanks Christian, commit on trunk at r1683642

          Show
          soledad Nicolas Malin added a comment - Thanks Christian, commit on trunk at r1683642
          Hide
          ofbizzer Christian Carlow added a comment -

          This patch fixes the last by assigning an empty string as default value to the id parameter. Otherwise this error occurs:

          FreeMarker template error: When calling macro "makeHyperlinkString", required parameter "id" (parameter #12) was not specified.

          Show
          ofbizzer Christian Carlow added a comment - This patch fixes the last by assigning an empty string as default value to the id parameter. Otherwise this error occurs: FreeMarker template error: When calling macro "makeHyperlinkString", required parameter "id" (parameter #12) was not specified.
          Hide
          ofbizzer Christian Carlow added a comment -

          Fixed in:
          trunk r1684066

          Show
          ofbizzer Christian Carlow added a comment - Fixed in: trunk r1684066
          Hide
          ofbizzer Christian Carlow added a comment -

          This is fairly trivial but my last fix was unnecessary because the problem for which it was to resolve was specific to my git repo. But <dropdown> id is set using the <field> id-name attribute. Does anyone think its worth patching this issue again to so that <field> id-name is used for <hyperlink> if it's id attribute isn't specified? If so then I'll remove the unnecessary fix from the last patch along with the necessary changes, otherwise I'll leave for now.

          Show
          ofbizzer Christian Carlow added a comment - This is fairly trivial but my last fix was unnecessary because the problem for which it was to resolve was specific to my git repo. But <dropdown> id is set using the <field> id-name attribute. Does anyone think its worth patching this issue again to so that <field> id-name is used for <hyperlink> if it's id attribute isn't specified? If so then I'll remove the unnecessary fix from the last patch along with the necessary changes, otherwise I'll leave for now.

            People

            • Assignee:
              soledad Nicolas Malin
              Reporter:
              ofbizzer Christian Carlow
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development