Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-6402

Replace FTL at webtools/control/entitymaint with widgets

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Implemented
    • Affects Version/s: Trunk
    • Fix Version/s: 16.11.01
    • Component/s: framework
    • Labels:
      None
    • Sprint:
      Community Day 2 - 2015
    1. OFBIZ-6402_4.patch
      10 kB
      Christian Carlow

      Issue Links

        Activity

        Hide
        ofbizzer Christian Carlow added a comment -

        This patch replaces framework/webtools/webapp/webtools/entity/EntityMaint.ftl with form widgets. Entities are listed 1 per row instead of two of the original FTL. If two per row is is preferred then I'm willing to reimplement that with widgets as well.

        The page seems to load slower overall which I'm assuming is due to the widget rendering logic.

        Also the tomahawk theme .condensed-table was added because an existing one wasn't found to make the entity search form fields display side-by-side similar to the FTL.

        Show
        ofbizzer Christian Carlow added a comment - This patch replaces framework/webtools/webapp/webtools/entity/EntityMaint.ftl with form widgets. Entities are listed 1 per row instead of two of the original FTL. If two per row is is preferred then I'm willing to reimplement that with widgets as well. The page seems to load slower overall which I'm assuming is due to the widget rendering logic. Also the tomahawk theme .condensed-table was added because an existing one wasn't found to make the entity search form fields display side-by-side similar to the FTL.
        Hide
        soledad Nicolas Malin added a comment -

        It's nice Christian.

        Quick review a little warning on your groovy code format (I haggle).

        With the ftl conversion to widget will have got many case with multi link on the list form. I think we need to improve the widget form to manage all links on one object like a menu.

        Show
        soledad Nicolas Malin added a comment - It's nice Christian. Quick review a little warning on your groovy code format (I haggle). With the ftl conversion to widget will have got many case with multi link on the list form. I think we need to improve the widget form to manage all links on one object like a menu.
        Hide
        adrianc@hlmksw.com Adrian Crum added a comment -

        This is a good start. The "Find By First Letter" feature doesn't work. The grid needs a link added to it. Also,

        <form name="ListEntities" type="list" ... >
        

        should be

        <grid name="ListEntities" ... >
        
        Show
        adrianc@hlmksw.com Adrian Crum added a comment - This is a good start. The "Find By First Letter" feature doesn't work. The grid needs a link added to it. Also, <form name= "ListEntities" type= "list" ... > should be <grid name= "ListEntities" ... >
        Hide
        ofbizzer Christian Carlow added a comment - - edited

        Should all trunk patches use <grid> over <form>? Does the "Find By First Letter" not work only for the grid or is it not working for the form also? The find link was given

        id="${firstChar}"

        to support the original FTL page section navigation.

        Show
        ofbizzer Christian Carlow added a comment - - edited Should all trunk patches use <grid> over <form>? Does the "Find By First Letter" not work only for the grid or is it not working for the form also? The find link was given id= "${firstChar}" to support the original FTL page section navigation.
        Hide
        ofbizzer Christian Carlow added a comment -

        Updating the patch again. Adrian, I understand the link not working now, I left out MacroFormRender code that allows form widget hyperlink id attribute to be set. The new patch contains all the changes to make the find by first letter functionality work. A separate issue should probably be created to support the <hyperlink> id attribute setting.

        Show
        ofbizzer Christian Carlow added a comment - Updating the patch again. Adrian, I understand the link not working now, I left out MacroFormRender code that allows form widget hyperlink id attribute to be set. The new patch contains all the changes to make the find by first letter functionality work. A separate issue should probably be created to support the <hyperlink> id attribute setting.
        Hide
        ofbizzer Christian Carlow added a comment -

        Updating patch again replacing <form> with <grid>

        Show
        ofbizzer Christian Carlow added a comment - Updating patch again replacing <form> with <grid>
        Hide
        adrianc@hlmksw.com Adrian Crum added a comment -

        Christian,

        I you want a single form, use the <form> widget, if you want a list or grid, use the <grid> widget. In both widgets, the type attribute is not needed. Your patch needs to be fixed.

        To clarify,

        <form type="list">
        

        has been replaced by

        <grid>
        

        and

        <form type="single">
        

        has been replaced by

        <form>
        

        I hope that makes sense.

        Show
        adrianc@hlmksw.com Adrian Crum added a comment - Christian, I you want a single form, use the <form> widget, if you want a list or grid, use the <grid> widget. In both widgets, the type attribute is not needed. Your patch needs to be fixed. To clarify, <form type= "list" > has been replaced by <grid> and <form type= "single" > has been replaced by <form> I hope that makes sense.
        Hide
        ofbizzer Christian Carlow added a comment -

        Thanks for the help Adrian,

        I removed the <grid> and <form> type attributes and made the search section a <form> again and left the list section a <grid>.

        Show
        ofbizzer Christian Carlow added a comment - Thanks for the help Adrian, I removed the <grid> and <form> type attributes and made the search section a <form> again and left the list section a <grid>.
        Hide
        ofbizzer Christian Carlow added a comment -

        OFBIZ-6403 is incorporated in this patch. A separate patch also exists for that issue which was extracted from this one.

        Show
        ofbizzer Christian Carlow added a comment - OFBIZ-6403 is incorporated in this patch. A separate patch also exists for that issue which was extracted from this one.
        Hide
        ofbizzer Christian Carlow added a comment -

        Hey Adrian,

        Will the type attribute still be available for <grid> for rendering "multi" type buttons?

        Show
        ofbizzer Christian Carlow added a comment - Hey Adrian, Will the type attribute still be available for <grid> for rendering "multi" type buttons?
        Hide
        soledad Nicolas Malin added a comment -

        done at revision 1686621 on trunk.

        Thanks Christian

        Show
        soledad Nicolas Malin added a comment - done at revision 1686621 on trunk. Thanks Christian

          People

          • Assignee:
            soledad Nicolas Malin
            Reporter:
            ofbizzer Christian Carlow
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development

                Agile