Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-5877

Add new address not workign on manage address screen

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: Release Branch 13.07, Trunk
    • Fix Version/s: 14.12.01, 12.04.06, 13.07.02
    • Component/s: ecommerce
    • Labels:
      None

      Description

      User is not able to add new address from manage address screen.
      Here is the steps to regenerate issue:

      1. OFBIZ-5877.patch
        2 kB
        Rishi Solanki

        Activity

        Hide
        rishisolankii Rishi Solanki added a comment - - edited

        Dig into the problem and replicate the issue on both 13.07 and trunk. The issue won't be duplicated for user id DemoCustomer at both the instance. Able to duplicate the issue for admin user at front store, issue is coming due to admin won't have the CUSTOMER role assigned. Error is coming for PartyContactMech insertion that admin won't have the customer role. We have two choices here;
        1) Add customer role data for admin. This will fix the problem.
        2) Give proper message to user on login and do not show the options to do that on front store.

        If community agree on any option I can provide patch accordingly. Thanks to Deepak Dixit for discussion on the solutions we may go for. Error coming on submit the form as below;

        (INSERT on table 'PARTY_CONTACT_MECH' caused a violation of foreign key constraint 'PARTY_CMECH_PROLE' for key (admin,CUSTOMER). The statement has been rolled back.)))
        
        Show
        rishisolankii Rishi Solanki added a comment - - edited Dig into the problem and replicate the issue on both 13.07 and trunk. The issue won't be duplicated for user id DemoCustomer at both the instance. Able to duplicate the issue for admin user at front store, issue is coming due to admin won't have the CUSTOMER role assigned. Error is coming for PartyContactMech insertion that admin won't have the customer role. We have two choices here; 1) Add customer role data for admin. This will fix the problem. 2) Give proper message to user on login and do not show the options to do that on front store. If community agree on any option I can provide patch accordingly. Thanks to Deepak Dixit for discussion on the solutions we may go for. Error coming on submit the form as below; (INSERT on table 'PARTY_CONTACT_MECH' caused a violation of foreign key constraint 'PARTY_CMECH_PROLE' for key (admin,CUSTOMER). The statement has been rolled back.)))
        Hide
        rishisolankii Rishi Solanki added a comment -

        The patch contains fix in service which check for the role type passed with party. Returns proper error message to user, no need to do anything permission or at any other level. It is service responsibility to check data coming in before forwarding to other service.

        Now instead of long error message, system returns an error which is easy to understand at user end. Requesting to check and push the fix, same patch applicable to both 13.07 and trunk.

        Show
        rishisolankii Rishi Solanki added a comment - The patch contains fix in service which check for the role type passed with party. Returns proper error message to user, no need to do anything permission or at any other level. It is service responsibility to check data coming in before forwarding to other service. Now instead of long error message, system returns an error which is easy to understand at user end. Requesting to check and push the fix, same patch applicable to both 13.07 and trunk.
        Hide
        toashishvijay Ashish Vijaywargiya added a comment -

        Thanks Rishi for the contribution and Thanks Deepak for creating the issue. Changes are committed in trunk at r1642409 and in R13.07 at r1642411.

        Show
        toashishvijay Ashish Vijaywargiya added a comment - Thanks Rishi for the contribution and Thanks Deepak for creating the issue. Changes are committed in trunk at r1642409 and in R13.07 at r1642411.
        Hide
        jacques.le.roux Jacques Le Roux added a comment -

        Backported in R12.04 at r1643386

        Show
        jacques.le.roux Jacques Le Roux added a comment - Backported in R12.04 at r1643386

          People

          • Assignee:
            toashishvijay Ashish Vijaywargiya
            Reporter:
            deepak.dixit Deepak Dixit
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development