OFBiz
  1. OFBiz
  2. OFBIZ-4784

storeIncomingEmail assumes variable is not null when it might be

    Details

      Description

      In storeIncomingEmail in CommunicationEventServices.java, the code to assemble the aboutThisEmail debugging message assumes addressesFrom and addressesTo are not null. But the methods that return values for those variables might return null if they encounter an exception.

      I have also removed uses of UtilValidate.isEmpty, which should only be used for collections and sequences (see OFBIZ-4427).

        Activity

        Paul Foxworthy created issue -
        Paul Foxworthy made changes -
        Field Original Value New Value
        Attachment OFBIZ-4784_CommunicationEventServices.patch [ 12521470 ]
        Jacques Le Roux made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Assignee Jacques Le Roux [ jacques.le.roux ]
        Fix Version/s Release Branch 10.04 [ 12314832 ]
        Fix Version/s Release Branch 11.04 [ 12316420 ]
        Fix Version/s SVN trunk [ 12311928 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Jacques Le Roux
            Reporter:
            Paul Foxworthy
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development