[OFBIZ-4784] storeIncomingEmail assumes variable is not null when it might be

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Trunk
• Fix Version/s: Release Branch 10.04, Release Branch 11.04, Trunk
• Component/s: party

Environment

r1309653

• Assignee: Jacques Le Roux
• Reporter: Paul Foxworthy
• Created: 05/Apr/12 07:43
• Updated: 05/Apr/12 09:29
• Resolved: 05/Apr/12 09:29

Description

In storeIncomingEmail in CommunicationEventServices.java, the code to assemble the aboutThisEmail debugging message assumes addressesFrom and addressesTo are not null. But the methods that return values for those variables might return null if they encounter an exception.

I have also removed uses of UtilValidate.isEmpty, which should only be used for collections and sequences (see OFBIZ-4427).