Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-12279

Macro renderLink default height and width not retrieved on menus

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Implemented
    • Trunk
    • None
    • ALL APPLICATIONS
    • None

    Description

      Menus link defaut parameters for height and width are not considered when the link is generated

      The problem seems to be that when parameter with empty value is passed to the macro,  macro default values are not retrieved.

      To reproduce

      you can create a "layered-modal" type link in a menu and click on the link (without height nor width):

      this will generate the link with parameters "data-dialog-height" and "data-dialog-width" empty

      Patch provided

      When applied, the MacroMenuRenderer.renderLink  will not send empty values to the macro so that default value will be retrieved (what is actually done on MacroFormRenderer.renderLookup)

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            jleroux Jacques Le Roux
            mleila Leila Mekika
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment