[OFBIZ-12279] Macro renderLink default height and width not retrieved on menus

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Implemented
• Affects Version/s: Trunk
• Component/s: ALL APPLICATIONS
• Assignee: Jacques Le Roux
• Reporter: Mekika Leila
• Created: 09/Jul/21 13:53
• Updated: 11/Jan/22 09:36
• Resolved: 12/Jul/21 10:44

Description

Menus link defaut parameters for height and width are not considered when the link is generated

The problem seems to be that when parameter with empty value is passed to the macro,  macro default values are not retrieved.

To reproduce

you can create a "layered-modal" type link in a menu and click on the link (without height nor width):

this will generate the link with parameters "data-dialog-height" and "data-dialog-width" empty

Patch provided

When applied, the MacroMenuRenderer.renderLink  will not send empty values to the macro so that default value will be retrieved (what is actually done on MacroFormRenderer.renderLookup)