Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-9350 Deprecate Mini Lang
  3. OFBIZ-11372

Convert createDownloadContent service from mini-lang to groovy DSL

Details

    • Sub-task
    • Status: Closed
    • Minor
    • Resolution: Implemented
    • Trunk
    • None
    • content
    • None
    • OFBiz Community Day (Feb 2020), OFBiz Community Day (May 2020), OFBiz Community Day (Aug 2020)

    Description

      Convert createDownloadContent service code from mini-lang to groovy DSL.

      Attachments

        1. OFBIZ-11372.patch
          4 kB
          Rahul Marjiwe

        Activity

          pawan Pawan Verma added a comment -

          Hello Rahul.marjiwe

          Thanks, for the great work. I think for code simplicity we can write the same code as:

          createOtherDataResourceMap = runService("createOtherDataResource",[dataResourceContent : parameters.file])

           

          Please let me know your thoughts on this. Thanks )

          pawan Pawan Verma added a comment - Hello Rahul.marjiwe Thanks, for the great work. I think for code simplicity we can write the same code as: createOtherDataResourceMap = runService("createOtherDataResource", [dataResourceContent : parameters.file] )   Please let me know your thoughts on this. Thanks )

          Commit 7aa3db4c45f55ab2cb8c471481bb75db7e8f980b in ofbiz-framework's branch refs/heads/trunk from Suraj Khurana
          [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=7aa3db4 ]

          Improved: Converted createDownloadContent,updateDownloadContent services from mini-lang to groovy.
          (OFBIZ-11372)(OFBIZ-11373)
          Thanks Devanshu Vyas for reporting, Harman Kaur and Rahul for initial patch, Pawan for review.

          jira-bot ASF subversion and git services added a comment - Commit 7aa3db4c45f55ab2cb8c471481bb75db7e8f980b in ofbiz-framework's branch refs/heads/trunk from Suraj Khurana [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=7aa3db4 ] Improved: Converted createDownloadContent,updateDownloadContent services from mini-lang to groovy. ( OFBIZ-11372 )( OFBIZ-11373 ) Thanks Devanshu Vyas for reporting, Harman Kaur and Rahul for initial patch, Pawan for review.
          surajk Suraj Khurana added a comment -

          Slightly modified patch uploaded into trunk.

           

          surajk Suraj Khurana added a comment - Slightly modified patch uploaded into trunk.  

          Commit 0caf66d514bafd5d3d2eacde2bc68ea439aa7f47 in ofbiz-framework's branch refs/heads/ecomify-OFBIZ-11468_Convert_ShipmentReceiptServices-squashed from Suraj Khurana
          [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=0caf66d ]

          Improved: Converted createDownloadContent,updateDownloadContent services from mini-lang to groovy.
          (OFBIZ-11372)(OFBIZ-11373)
          Thanks Devanshu Vyas for reporting, Harman Kaur and Rahul for initial patch, Pawan for review.

          jira-bot ASF subversion and git services added a comment - Commit 0caf66d514bafd5d3d2eacde2bc68ea439aa7f47 in ofbiz-framework's branch refs/heads/ecomify- OFBIZ-11468 _Convert_ShipmentReceiptServices-squashed from Suraj Khurana [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=0caf66d ] Improved: Converted createDownloadContent,updateDownloadContent services from mini-lang to groovy. ( OFBIZ-11372 )( OFBIZ-11373 ) Thanks Devanshu Vyas for reporting, Harman Kaur and Rahul for initial patch, Pawan for review.

          People

            surajk Suraj Khurana
            devanshu Devanshu Vyas
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: