[OFBIZ-10926] Update an order linked to an other order lost relation

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 16.11.05, Release Branch 18.12, Release Branch 17.12, Trunk
• Fix Version/s: 16.11.06, 17.12.01, 18.12.01
• Component/s: order
• Assignee: Nicolas Malin
• Reporter: Nicolas Malin
• Created: 15/Apr/19 22:09
• Updated: 11/Jan/22 09:37
• Resolved: 15/Apr/19 22:16

Description

When you edit an order linked to an other order like drop shipment process, shopping cart lost the connexion.

The problem came from ShoppingCart.makeAllOrderItemAssociations() function that prepared all generic value OrderItemAssoc without toOrderId

Index: applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCart.java
===================================================================
--- applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCart.java (révision 1857601)
+++ applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCart.java (copie de travail)
@@ -4122,6 +4122,7 @@
   orderItemAssociation.set("orderId", commitment.getString("orderId"));
   orderItemAssociation.set("orderItemSeqId", commitment.getString("orderItemSeqId"));
   orderItemAssociation.set("shipGroupSeqId", "_NA_");
+  orderItemAssociation.set("toOrderId", this.getOrderId());
   orderItemAssociation.set("toOrderItemSeqId", item.getOrderItemSeqId());
   orderItemAssociation.set("toShipGroupSeqId", "_NA_");
   orderItemAssociation.set("orderItemAssocTypeId", "PURCHASE_ORDER");
@@ -4136,6 +4137,7 @@
   orderItemAssociation.set("orderId", item.getAssociatedOrderId());
   orderItemAssociation.set("orderItemSeqId", item.getAssociatedOrderItemSeqId());
   orderItemAssociation.set("shipGroupSeqId", csi.getAssociatedShipGroupSeqId() != null ? csi.getAssociatedShipGroupSeqId() : "_NA_");
+  orderItemAssociation.set("toOrderId", this.getOrderId());
   orderItemAssociation.set("toOrderItemSeqId", item.getOrderItemSeqId());
   orderItemAssociation.set("toShipGroupSeqId", csi.getShipGroupSeqId() != null ? csi.getShipGroupSeqId() : "_NA_");
   orderItemAssociation.set("orderItemAssocTypeId", item.getOrderItemAssocTypeId());