Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-10926

Update an order linked to an other order lost relation

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 16.11.05, Release Branch 18.12, Release Branch 17.12, Trunk
    • 16.11.06, 17.12.01, 18.12.01
    • order
    • None

    Description

      When you edit an order linked to an other order like drop shipment process, shopping cart lost the connexion.

      The problem came from ShoppingCart.makeAllOrderItemAssociations() function that prepared all generic value OrderItemAssoc without toOrderId

      Index: applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCart.java
      ===================================================================
      --- applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCart.java (révision 1857601)
      +++ applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCart.java (copie de travail)
      @@ -4122,6 +4122,7 @@
         orderItemAssociation.set("orderId", commitment.getString("orderId"));
         orderItemAssociation.set("orderItemSeqId", commitment.getString("orderItemSeqId"));
         orderItemAssociation.set("shipGroupSeqId", "_NA_");
      +  orderItemAssociation.set("toOrderId", this.getOrderId());
         orderItemAssociation.set("toOrderItemSeqId", item.getOrderItemSeqId());
         orderItemAssociation.set("toShipGroupSeqId", "_NA_");
         orderItemAssociation.set("orderItemAssocTypeId", "PURCHASE_ORDER");
      @@ -4136,6 +4137,7 @@
         orderItemAssociation.set("orderId", item.getAssociatedOrderId());
         orderItemAssociation.set("orderItemSeqId", item.getAssociatedOrderItemSeqId());
         orderItemAssociation.set("shipGroupSeqId", csi.getAssociatedShipGroupSeqId() != null ? csi.getAssociatedShipGroupSeqId() : "_NA_");
      +  orderItemAssociation.set("toOrderId", this.getOrderId());
         orderItemAssociation.set("toOrderItemSeqId", item.getOrderItemSeqId());
         orderItemAssociation.set("toShipGroupSeqId", csi.getShipGroupSeqId() != null ? csi.getShipGroupSeqId() : "_NA_");
         orderItemAssociation.set("orderItemAssocTypeId", item.getOrderItemAssocTypeId());

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            nmalin Nicolas Malin
            nmalin Nicolas Malin
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment