[OAK-9863] Composite Store ITs fail due to failing NodeTypeDefinitionNodeStoreChecker

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: composite
• Assignee: Unassigned
• Reporter: Konrad Windszus
• Created: 26/Jul/22 15:38
• Updated: 26/Jul/22 15:45

Description

Both composite node store ITs

1. https://github.com/apache/jackrabbit-oak/blob/trunk/oak-store-composite/src/test/java/org/apache/jackrabbit/oak/composite/it/BackwardCompatibleMountCompositeIT.java and
2. https://github.com/apache/jackrabbit-oak/blob/trunk/oak-store-composite/src/test/java/org/apache/jackrabbit/oak/composite/it/MultiMountCompositeIT.java

fail due to returning null for the primaryType of the root node in https://github.com/apache/jackrabbit-oak/blob/03b95f8005302b7a739bc8ac7ad5808a3cd7e7f5/oak-store-composite/src/main/java/org/apache/jackrabbit/oak/composite/checks/NodeTypeDefinitionNodeStoreChecker.java#L77

That leads to the following errors

ERROR: bundle org.apache.jackrabbit.oak-store-composite:1.45.0.SNAPSHOT (52)[org.apache.jackrabbit.oak.composite.CompositeNodeStoreService(53)] : The activate method has thrown an exception
org.apache.jackrabbit.oak.api.IllegalRepositoryStateException: 18 errors were found: 
For NodeStore mount libs, path /, encountered the following problem: 'The primary type null does not exist'
For NodeStore mount libs, path /, encountered the following problem: 'No default primary type available  for child node libs'
For NodeStore mount libs, path /libs, encountered the following problem: 'The primary type null does not exist'
For NodeStore mount libs, path /libs, encountered the following problem: 'No default primary type available  for child node libsMount'
For NodeStore mount libs, path /libs/libsMount, encountered the following problem: 'The primary type null does not exist'
For NodeStore mount libs, path /, encountered the following problem: 'No default primary type available  for child node apps'
For NodeStore mount libs, path /apps, encountered the following problem: 'The primary type null does not exist'
For NodeStore mount libs, path /apps, encountered the following problem: 'No default primary type available  for child node libsMount'
For NodeStore mount libs, path /apps/libsMount, encountered the following problem: 'The primary type null does not exist'
For NodeStore mount libs, path /, encountered the following problem: 'The primary type null does not exist'
For NodeStore mount libs, path /, encountered the following problem: 'No default primary type available  for child node libs'
For NodeStore mount libs, path /libs, encountered the following problem: 'The primary type null does not exist'
For NodeStore mount libs, path /libs, encountered the following problem: 'No default primary type available  for child node libsMount'
For NodeStore mount libs, path /libs/libsMount, encountered the following problem: 'The primary type null does not exist'
For NodeStore mount libs, path /, encountered the following problem: 'No default primary type available  for child node apps'
For NodeStore mount libs, path /apps, encountered the following problem: 'The primary type null does not exist'
For NodeStore mount libs, path /apps, encountered the following problem: 'No default primary type available  for child node libsMount'
For NodeStore mount libs, path /apps/libsMount, encountered the following problem: 'The primary type null does not exist'

That is due to the fact that the IT relies on empty segment node stores which don't even have a primary type set for the root node.

Reproducability is a bit hard due to the race condition mentioned in OAK-9841

Issue Links

• Discovered while testing: OAK-9800 Update Maven Plugins and Apache Parent POM to version 29
• is broken by: OAK-9553 Enable configuration of more than one read-only mount in the composite node store
• relates to: OAK-9841 Race condition in NodeStoreChecksService

Sub-Tasks

• CompositeStoreIT: add workaround for potential NPE in test: Closed