[OAK-9841] Race condition in NodeStoreChecksService

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: composite
• Assignee: Unassigned
• Reporter: Konrad Windszus
• Created: 15/Jul/22 14:48
• Updated: 18/Aug/22 11:02

Description

The NodeStoreChecksService (https://github.com/apache/jackrabbit-oak/blob/bbc141fd1fb9ff0d9ce742279445df9eb698c3e3/oak-store-composite/src/main/java/org/apache/jackrabbit/oak/composite/checks/NodeStoreChecksService.java#L41) executes all bound MountedNodeStoreChecker s which have been there at the time of activation.
The references are not greedily referenced and also there is no wait for specific MountedNodeStoreChecker services to be active.
That leads to the fact that the usage of NodeStoreChecksService in CompositeNodeStoreService.registerCompositeNodeStore(...) is not deterministic as the starting order of OSGi services determine which MountedNodeStoreChecker are active during CompositeNodeStoreService.activate().

Issue Links

• Discovered while testing: OAK-9800 Update Maven Plugins and Apache Parent POM to version 29
• is related to: OAK-9863 Composite Store ITs fail due to failing NodeTypeDefinitionNodeStoreChecker
• is related to: OAK-9846 o.a.j.oak.composite.ErrorHolder should include the name of the checker for each report
• relates to: OAK-4891 Mount-time sanity checks for mounted NodeStore instances