[OAK-8750] SegmentStoreMigrator should catch and log exceptions thrown while migrating archives

• Type: Task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.20.0
• Component/s: segment-azure
• Assignee: Andrei Dulceanu
• Reporter: Andrei Dulceanu
• Created: 08/Nov/19 10:55
• Updated: 08/Nov/19 11:56
• Resolved: 08/Nov/19 11:28

Description

Current logic used in migrating archives in SegmentStoreMigrator silently swallows exceptions coming from the segment, binary refs and graph migration methods:

try (SegmentArchiveReader reader = sourceManager.forceOpen(archiveName)) {
    SegmentArchiveWriter writer = targetManager.create(archiveName);
    try {
        migrateSegments(reader, writer);
        migrateBinaryRef(reader, writer);
        migrateGraph(reader, writer);
    } finally {
        writer.close();
    }
}

Adding a catch block which logs the possible exceptions would make analysing logs easier.