Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-8750

SegmentStoreMigrator should catch and log exceptions thrown while migrating archives

    XMLWordPrintableJSON

Details

    • Task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.20.0
    • segment-azure
    • None

    Description

      Current logic used in migrating archives in SegmentStoreMigrator silently swallows exceptions coming from the segment, binary refs and graph migration methods:

      try (SegmentArchiveReader reader = sourceManager.forceOpen(archiveName)) {
          SegmentArchiveWriter writer = targetManager.create(archiveName);
          try {
              migrateSegments(reader, writer);
              migrateBinaryRef(reader, writer);
              migrateGraph(reader, writer);
          } finally {
              writer.close();
          }
      }
      

      Adding a catch block which logs the possible exceptions would make analysing logs easier.

      Attachments

        1. OAK-8750.patch
          0.9 kB
          Andrei Dulceanu

        Activity

          People

            adulceanu Andrei Dulceanu
            adulceanu Andrei Dulceanu
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: