Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-8139

DocumentDiscoveryLiteService hasBacklog silencing must support maven version format

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 1.8.13, 1.10.3, 1.14.0
    • documentmk
    • None

    Description

      OAK-3492 silences log warns when it encounters an 1.0 or 1.2 oak version (in the case where there is an inactive cluster node that doesn't have lastWrittenRootRev set).

      The silencing uses osgi Version to do the version comparison, however the actual version is stored in maven format. This breaks for eg the case where version is set to something like 1.0.10-SNAPSHOT where it expects 1.0.10.SNAPSHOT and the following exception would occur:
      org.apache.jackrabbit.oak.plugins.document.DocumentDiscoveryLiteService hasBacklog: couldn't parse version 1.0.10-SNAPSHOT : java.lang.IllegalArgumentException: invalid version "1.0.10-SNAPSHOT": non-numeric "10-SNAPSHOT"

      The silencing should be fixed.

      Attachments

        1. OAK-8139.diff
          4 kB
          Julian Reschke
        2. OAK-8139.patch2.diff
          4 kB
          Stefan Egli
        3. OAK-8139.patch3.diff
          6 kB
          Stefan Egli

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            reschke Julian Reschke
            stefanegli Stefan Egli
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment