[OAK-8139] DocumentDiscoveryLiteService hasBacklog silencing must support maven version format

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.8.13, 1.10.3, 1.14.0
• Component/s: documentmk
• Assignee: Julian Reschke
• Reporter: Stefan Egli
• Created: 18/Mar/19 12:49
• Updated: 09/Nov/21 13:30
• Resolved: 16/Apr/19 10:02

Description

OAK-3492 silences log warns when it encounters an 1.0 or 1.2 oak version (in the case where there is an inactive cluster node that doesn't have lastWrittenRootRev set).

The silencing uses osgi Version to do the version comparison, however the actual version is stored in maven format. This breaks for eg the case where version is set to something like 1.0.10-SNAPSHOT where it expects 1.0.10.SNAPSHOT and the following exception would occur:
org.apache.jackrabbit.oak.plugins.document.DocumentDiscoveryLiteService hasBacklog: couldn't parse version 1.0.10-SNAPSHOT : java.lang.IllegalArgumentException: invalid version "1.0.10-SNAPSHOT": non-numeric "10-SNAPSHOT"

The silencing should be fixed.

Issue Links

• causes: OAK-9130 DocumentDiscoveryLiteService.hasBacklog logging regression (inverted version check)
• is caused by: OAK-3492 reduce DocumentDiscoveryLiteService hasBacklog WARNs