[OAK-6051] Clarify migration tests failures when switching Commit#hasChanges implementations

• Type: Task
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.7.3, 1.8.0
• Component/s: segment-tar
• Epic Link: TarMK transaction rate
• Assignee: Andrei Dulceanu
• Reporter: Andrei Dulceanu
• Created: 06/Apr/17 15:25
• Updated: 06/Jul/17 15:34
• Resolved: 11/Apr/17 15:03

Description

Currently, the implementation used to tell if there are changes in a commit to be merged (comparing the base state against the node state) uses SegmentNodeState#fastEquals directly (and consequently making that method public). Although comparing the node states through equals, which in turn should then delegate to fastEquals, should work, the following tests are failing when using this method:

Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.41 sec <<< FAILURE! - in org.apache.jackrabbit.oak.segment.migration.ExternalToExternalMigrationTest
blobsExistsOnTheNewBlobStore(org.apache.jackrabbit.oak.segment.migration.ExternalToExternalMigrationTest)  Time elapsed: 0.082 sec  <<< ERROR!
java.io.IOException: java.lang.NullPointerException
Caused by: java.lang.NullPointerException

Running org.apache.jackrabbit.oak.segment.migration.SegmentToExternalMigrationTest
Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.163 sec <<< FAILURE! - in org.apache.jackrabbit.oak.segment.migration.SegmentToExternalMigrationTest
blobsExistsOnTheNewBlobStore(org.apache.jackrabbit.oak.segment.migration.SegmentToExternalMigrationTest)  Time elapsed: 0.062 sec  <<< ERROR!
java.io.IOException: java.lang.NullPointerException
Caused by: java.lang.NullPointerException

Issue Links

• is related to: OAK-6066 Migration of binaries relies on implementation details of the TarMK