Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-6051

Clarify migration tests failures when switching Commit#hasChanges implementations

    XMLWordPrintableJSON

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.7.3, 1.8.0
    • Component/s: segment-tar
    • Labels:
      None

      Description

      Currently, the implementation used to tell if there are changes in a commit to be merged (comparing the base state against the node state) uses SegmentNodeState#fastEquals directly (and consequently making that method public). Although comparing the node states through equals, which in turn should then delegate to fastEquals, should work, the following tests are failing when using this method:

      Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.41 sec <<< FAILURE! - in org.apache.jackrabbit.oak.segment.migration.ExternalToExternalMigrationTest
      blobsExistsOnTheNewBlobStore(org.apache.jackrabbit.oak.segment.migration.ExternalToExternalMigrationTest)  Time elapsed: 0.082 sec  <<< ERROR!
      java.io.IOException: java.lang.NullPointerException
      Caused by: java.lang.NullPointerException
      
      Running org.apache.jackrabbit.oak.segment.migration.SegmentToExternalMigrationTest
      Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.163 sec <<< FAILURE! - in org.apache.jackrabbit.oak.segment.migration.SegmentToExternalMigrationTest
      blobsExistsOnTheNewBlobStore(org.apache.jackrabbit.oak.segment.migration.SegmentToExternalMigrationTest)  Time elapsed: 0.062 sec  <<< ERROR!
      java.io.IOException: java.lang.NullPointerException
      Caused by: java.lang.NullPointerException
      

        Attachments

        1. OAK-6051.patch
          2 kB
          Andrei Dulceanu

          Issue Links

            Activity

              People

              • Assignee:
                adulceanu Andrei Dulceanu
                Reporter:
                adulceanu Andrei Dulceanu
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: