[OAK-567] DiffBuilder performance problem

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.11
• Component/s: mk
• Assignee: Stefan Guggisberg
• Reporter: Thomas Mueller
• Created: 17/Jan/13 14:05
• Updated: 21/Nov/13 10:30
• Resolved: 07/Nov/13 13:12

Description

The org.apache.jackrabbit.mk.model.tree.DiffBuilder is very slow because it uses:

HashMap<NodeState, String>

and at the same time

class AbstractNodeState implements NodeState {
        /**
     * Returns a hash code that's compatible with how the
     * {@link #equals(Object)} method is implemented. The current
     * implementation simply returns zero for everything since
     * {@link NodeState} instances are not intended for use as hash keys.
     *
     * @return hash code
     */
    @Override
    public int hashCode() {
        return 0;
    }
}

Issue Links

• is part of: OAK-997 cleanup codebase: remove unneeded internal abstraction