Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-5253

Optimize AbstractBlob#equal to not do content equals when possible

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Won't Fix
    • None
    • None
    • blob
    • None

    Description

      AbstractBlob#equals tries to match content when length is equal and content identities is not null and different. Matching content triggers an expensive download of binaries for S3DataStore.
      Since, right now the content identity is the content hash the check can be short -circuited when the content identities is not null and not equal to return false.

      This can be revisited if we change the identity to something different.

      Attachments

        1. OAK-5253.1.patch
          3 kB
          Matt Ryan

        Issue Links

          relates to

          Improvement - An improvement or enhancement to an existing feature or task. OAK-9466 APIs to determine the equality of blobs

          • Major - Major loss of function.
          • Open

          Improvement - An improvement or enhancement to an existing feature or task. OAK-4789 SegmentBlob should return null contentIdentity for inlined blobs

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            People

              amitjain Amit Jain
              amitjain Amit Jain
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: