[OAK-4789] SegmentBlob should return null contentIdentity for inlined blobs

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.4.11, 1.5.13, 1.6.0
• Component/s: segment-tar, segmentmk
• Assignee: Chetan Mehrotra
• Reporter: Chetan Mehrotra
• Created: 12/Sep/16 03:04
• Updated: 09/Dec/16 07:05
• Resolved: 02/Nov/16 15:18

Description

When a external BlobStore is configured with SegmentNodeStore then blob can exist in 3 forms

1. Blob inlined in segment storage - If blob length is <= 16512 then blob would be inlined in segment store
2. Blob inlined in BlobStore - Most BlobStore implementation also support inlining of blob content as part of blobId if the size is less than certain threshold. For FileDataStore this is determined by minRecordLength. If this is less than #1 then such a case would not happen
3. Blob whose content are stored in BlobStore without inlining

Currently SegmentBlob returns recordId for getContentIdentity call for inlined blobs. This would cause this value to change if same blob is stored in a different segmentstore. As discussed here this causes ambiguity in certain cases.

Given that getContentIdentity can return null it would be better if SegmentBlob returns null for inlined blob.

Issue Links

• is related to: OAK-5009 ExternalToExternalMigrationTest failures on Windows
• is related to: OAK-5253 Optimize AbstractBlob#equal to not do content equals when possible
• is required by: OAK-4712 Publish S3DataStore stats in JMX MBean